Skip to content

Commit a8b4a43

Browse files
authored
Merge pull request #39 from yappbox/chore/update-dependencies
Dependency updates
2 parents 7ab2468 + b37390f commit a8b4a43

File tree

10 files changed

+1105
-598
lines changed

10 files changed

+1105
-598
lines changed

.eslintrc.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
'use strict';
2+
13
module.exports = {
24
root: true,
35
parser: 'babel-eslint',

.travis.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,15 @@ jobs:
3535
- stage: "Tests"
3636
name: "Tests"
3737
script:
38-
- npm run lint:js
39-
- npm test
38+
- yarn lint
39+
- yarn test:ember
4040

4141
- stage: "Additional Tests"
4242
name: "Floating Dependencies"
4343
install:
4444
- npm install --no-package-lock
4545
script:
46-
- npm test
46+
- yarn test:ember
4747

4848
# we recommend new addons test the current and previous LTS
4949
# as well as latest stable release (bonus points to beta/canary)

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@
2323
* `ember serve`
2424
* Visit the dummy application at [http://localhost:4200](http://localhost:4200).
2525

26-
For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).
26+
For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).

package.json

Lines changed: 26 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -17,61 +17,64 @@
1717
},
1818
"scripts": {
1919
"build": "ember build --environment=production",
20+
"lint": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*",
2021
"lint:js": "eslint .",
2122
"release": "release-it",
2223
"start": "ember serve",
23-
"test": "ember test",
24-
"test:all": "ember try:each"
24+
"test": "npm-run-all lint:* test:*",
25+
"test:ember": "ember test",
26+
"test:ember-compatibility": "ember try:each"
2527
},
2628
"dependencies": {
2729
"@ember/render-modifiers": "^1.0.2",
2830
"@glimmer/tracking": "^1.0.0",
2931
"ember-auto-import": "^1.5.3",
30-
"ember-cli-babel": "7.17.2",
31-
"ember-cli-htmlbars": "^4.2.2",
32-
"ember-composable-helpers": "^4.0.0",
33-
"ember-concurrency": "^1.1.5",
32+
"ember-cli-babel": "7.20.5",
33+
"ember-cli-htmlbars": "^5.1.2",
34+
"ember-composable-helpers": "^4.1.3",
35+
"ember-concurrency": "^1.1.7",
3436
"ember-concurrency-decorators": "^1.0.0",
3537
"ember-decorators": "^6.1.1",
3638
"hammerjs": "^2.0.8"
3739
},
3840
"devDependencies": {
39-
"@babel/core": "^7.9.0",
41+
"@babel/core": "^7.10.2",
4042
"@ember/optional-features": "^1.3.0",
4143
"@glimmer/component": "^1.0.0",
42-
"babel-eslint": "^10.0.3",
44+
"babel-eslint": "^10.1.0",
4345
"broccoli-asset-rev": "^3.0.0",
44-
"ember-cli": "~3.16.0",
46+
"ember-cli": "~3.18.0",
4547
"ember-cli-dependency-checker": "^3.2.0",
4648
"ember-cli-deploy": "^1.0.2",
47-
"ember-cli-deploy-build": "^1.1.1",
49+
"ember-cli-deploy-build": "^2.0.0",
4850
"ember-cli-deploy-git": "^1.3.3",
49-
"ember-cli-eslint": "^5.1.0",
5051
"ember-cli-inject-live-reload": "^2.0.2",
51-
"ember-cli-sass": "^8.0.1",
52+
"ember-cli-sass": "^10.0.1",
5253
"ember-cli-sri": "^2.1.1",
5354
"ember-cli-uglify": "^3.0.0",
54-
"ember-collection": "1.0.0-alpha.9",
55-
"ember-decorators-polyfill": "^1.1.1",
55+
"ember-collection": "1.0.0-rc.0",
56+
"ember-decorators-polyfill": "^1.1.5",
5657
"ember-disable-prototype-extensions": "^1.1.3",
5758
"ember-export-application-global": "^2.0.1",
5859
"ember-load-initializers": "^2.1.1",
5960
"ember-maybe-import-regenerator": "^0.1.6",
6061
"ember-qunit": "^4.6.0",
61-
"ember-resolver": "^7.0.0",
62-
"ember-simulant-test-helpers": "^0.3.0",
63-
"ember-source": "~3.16.0",
62+
"ember-resolver": "^8.0.0",
63+
"ember-simulant-test-helpers": "^0.3.1",
64+
"ember-source": "~3.18.0",
6465
"ember-source-channel-url": "^2.0.1",
66+
"ember-template-lint": "^2.6.0",
6567
"ember-try": "^1.4.0",
66-
"eslint": "^6.8.0",
67-
"eslint-plugin-ember": "^7.7.2",
68-
"eslint-plugin-node": "^11.0.0",
68+
"eslint": "^7.2.0",
69+
"eslint-plugin-ember": "^8.4.0",
70+
"eslint-plugin-node": "^11.1.0",
6971
"layout-bin-packer": "^1.2.0",
7072
"loader.js": "^4.7.0",
71-
"qunit-dom": "^1.0.0",
72-
"release-it": "^13.6.0",
73+
"npm-run-all": "^4.1.5",
74+
"qunit-dom": "^1.2.0",
75+
"release-it": "^13.6.2",
7376
"release-it-lerna-changelog": "^2.3.0",
74-
"sass": "^1.15.1"
77+
"sass": "^1.26.8"
7578
},
7679
"engines": {
7780
"node": "10.* || >= 12"

testem.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
'use strict';
2+
13
module.exports = {
24
test_page: 'tests/index.html?hidepassed',
35
disable_watching: true,
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
{
2+
"schemaVersion": "1.0.0",
3+
"packages": [
4+
{
5+
"name": "ember-cli",
6+
"version": "3.18.0",
7+
"blueprints": [
8+
{
9+
"name": "addon",
10+
"outputRepo": "https://github.com/ember-cli/ember-addon-output",
11+
"codemodsSource": "ember-addon-codemods-manifest@1",
12+
"isBaseBlueprint": true,
13+
"options": [
14+
"--yarn",
15+
"--no-welcome"
16+
]
17+
}
18+
]
19+
}
20+
]
21+
}

tests/integration/components/collection-scroll-view-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ module('Integration | Component | collection-scroll-view', function(hooks) {
6161
amount: 400
6262
});
6363
await waitForOpacity(SCROLLBAR_THUMB, '1');
64-
assert.equal(find(SCROLLBAR_THUMB).offsetHeight, 229);
64+
assert.equal(find(SCROLLBAR_THUMB).offsetHeight, 230);
6565
await scrollPromise;
6666
assert.ok(scrollPosition(find(SCROLL_CONTAINER)) <= -390);
6767
assert.dom(SCROLL_CONTAINER).containsText('Ten');

tests/integration/components/scroll-view-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ module('Integration | Component | scroll-view', function(hooks) {
7272
await this.render(EXAMPLE_1_HBS);
7373
let scrollPromise = scrollDown('.ScrollView #element1');
7474
await waitForOpacity(SCROLLBAR_THUMB, '1');
75-
assert.equal(find(SCROLLBAR_THUMB).offsetHeight, 229);
75+
assert.equal(find(SCROLLBAR_THUMB).offsetHeight, 230);
7676
await scrollPromise;
7777
assert.ok(scrollPosition(find(SCROLL_CONTAINER)) <= -190);
7878
});

tests/integration/components/vertical-scroll-bar-test.js

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ module('Integration | Component | vertical-scroll-bar', function(hooks) {
5454
test('it renders with a thumb size proportional to content ratio', async function(assert) {
5555
await this.render(EXAMPLE_1_HBS);
5656
this.simulateCallback(true, 100);
57-
assert.equal(thumbSize(), 233);
57+
assert.equal(thumbSize(), 234);
5858
assert.equal(thumbPosition(), 48);
5959
assert.equal(find(THUMB).style.opacity, "1");
6060
});
@@ -64,7 +64,7 @@ module('Integration | Component | vertical-scroll-bar', function(hooks) {
6464
await this.render(EXAMPLE_1_HBS);
6565
this.simulateCallback(true, 5);
6666
this.simulateCallback(true, 0);
67-
assert.equal(thumbSize(), 480);
67+
assert.equal(thumbSize(), 481);
6868
assert.equal(thumbPosition(), 0);
6969
assert.equal(find(THUMB).style.opacity, "1");
7070
});
@@ -78,7 +78,7 @@ module('Integration | Component | vertical-scroll-bar', function(hooks) {
7878
this.set('contentHeight', 100000);
7979
await this.render(EXAMPLE_1_HBS);
8080
this.simulateCallback(true, 100);
81-
assert.equal(thumbSize(), 16);
81+
assert.equal(thumbSize(), 17);
8282
});
8383

8484
test('thumb is visible when isScrolling is true', async function(assert) {
@@ -95,13 +95,13 @@ module('Integration | Component | vertical-scroll-bar', function(hooks) {
9595
await this.render(EXAMPLE_1_HBS);
9696
this.simulateCallback(true, -100);
9797
assert.equal(thumbPosition(), 0, 'thumb is at top');
98-
assert.equal(thumbSize(), 193, 'thumb height is compressed');
98+
assert.equal(thumbSize(), 195, 'thumb height is compressed');
9999
});
100100

101101
test('compresses scrollbar when overscrolled at bottom', async function(assert) {
102102
await this.render(EXAMPLE_1_HBS);
103103
this.simulateCallback(true, 650);
104-
assert.equal(thumbSize(), 182, 'thumb height is compressed');
104+
assert.equal(thumbSize(), 184, 'thumb height is compressed');
105105
assert.equal(thumbPosition(), 298, 'thumb is at bottom');
106106
});
107107

@@ -110,14 +110,14 @@ module('Integration | Component | vertical-scroll-bar', function(hooks) {
110110
await this.render(EXAMPLE_1_HBS);
111111
this.simulateCallback(true, -100);
112112
assert.equal(thumbPosition(), 0, 'thumb is at top');
113-
assert.equal(thumbSize(), 397, 'thumb height is compressed');
113+
assert.equal(thumbSize(), 399, 'thumb height is compressed');
114114
});
115115

116116
test('compresses scrollbar when overscrolled at bottom, short content', async function(assert) {
117117
this.set('contentHeight', 300);
118118
await this.render(EXAMPLE_1_HBS);
119119
this.simulateCallback(true, 400);
120-
assert.equal(thumbSize(), 263, 'thumb height is compressed');
120+
assert.equal(thumbSize(), 265, 'thumb height is compressed');
121121
assert.equal(thumbPosition(), 217, 'thumb is at bottom');
122122
});
123123

@@ -130,22 +130,22 @@ module('Integration | Component | vertical-scroll-bar', function(hooks) {
130130
// when scrolled past bottom by 5
131131
this.simulateCallback(true, 105);
132132
assert.equal(thumbPosition(), 95, 'thumb is at bottom');
133-
assert.equal(thumbSize(), 905, 'thumb is slightly compressed');
133+
assert.equal(thumbSize(), 907, 'thumb is slightly compressed');
134134

135135
// when scrolled past top by 5
136136
this.simulateCallback(true, -5);
137137
assert.equal(thumbPosition(), 0, 'thumb is at top');
138-
assert.equal(thumbSize(), 995, 'thumb is slightly compressed');
138+
assert.equal(thumbSize(), 996, 'thumb is slightly compressed');
139139

140140
// when scrolled past bottom by 100
141141
this.simulateCallback(true, 100);
142142
assert.equal(thumbPosition(), 90, 'thumb is at bottom');
143-
assert.equal(thumbSize(), 910, 'thumb is slightly compressed');
143+
assert.equal(thumbSize(), 911, 'thumb is slightly compressed');
144144

145145
// when scrolled past top by 100
146146
this.simulateCallback(true, -100);
147147
assert.equal(thumbPosition(), 0, 'thumb is at top');
148-
assert.equal(thumbSize(), 909, 'thumb is slightly compressed');
148+
assert.equal(thumbSize(), 910, 'thumb is slightly compressed');
149149
});
150150

151151
test('behavior when content is equal to scrollview height', async function(assert) {
@@ -157,22 +157,22 @@ module('Integration | Component | vertical-scroll-bar', function(hooks) {
157157
// when scrolled past bottom by 5
158158
this.simulateCallback(true, 5);
159159
assert.equal(thumbPosition(), 4, 'thumb is at bottom');
160-
assert.equal(thumbSize(), 996, 'thumb is slightly compressed');
160+
assert.equal(thumbSize(), 997, 'thumb is slightly compressed');
161161

162162
// when scrolled past top by 5
163163
this.simulateCallback(true, -5);
164164
assert.equal(thumbPosition(), 0, 'thumb is at top');
165-
assert.equal(thumbSize(), 995, 'thumb is slightly compressed');
165+
assert.equal(thumbSize(), 996, 'thumb is slightly compressed');
166166

167167
// when scrolled past bottom by 100
168168
this.simulateCallback(true, 100);
169169
assert.equal(thumbPosition(), 90, 'thumb is at bottom');
170-
assert.equal(thumbSize(), 910, 'thumb is slightly compressed');
170+
assert.equal(thumbSize(), 911, 'thumb is slightly compressed');
171171

172172
// when scrolled past top by 100
173173
this.simulateCallback(true, -100);
174174
assert.equal(thumbPosition(), 0, 'thumb is at top');
175-
assert.equal(thumbSize(), 909, 'thumb is slightly compressed');
175+
assert.equal(thumbSize(), 910, 'thumb is slightly compressed');
176176
});
177177

178178
test('behavior when content is slightly more than scrollview height', async function(assert) {
@@ -184,27 +184,27 @@ module('Integration | Component | vertical-scroll-bar', function(hooks) {
184184
// when scrolled past bottom by 1
185185
this.simulateCallback(true, 101);
186186
assert.equal(thumbPosition(), 90, 'thumb is at bottom');
187-
assert.equal(thumbSize(), 810, 'thumb is slightly compressed');
187+
assert.equal(thumbSize(), 811, 'thumb is slightly compressed');
188188

189189
// when scrolled past top by 1
190190
this.simulateCallback(true, -1);
191191
assert.equal(thumbPosition(), 0, 'thumb is at top');
192-
assert.equal(thumbSize(), 810, 'thumb is slightly compressed');
192+
assert.equal(thumbSize(), 811, 'thumb is slightly compressed');
193193

194194
// when scrolled to center
195195
this.simulateCallback(true, 50);
196196
assert.equal(thumbPosition(), 45, 'thumb is in center');
197-
assert.equal(thumbSize(), 811, 'thumb height is not compressed');
197+
assert.equal(thumbSize(), 812, 'thumb height is not compressed');
198198

199199
// when scrolled past bottom by 200
200200
this.simulateCallback(true, 300);
201201
assert.equal(thumbPosition(), 237, 'thumb is at bottom');
202-
assert.equal(thumbSize(), 663, 'thumb is heavily compressed');
202+
assert.equal(thumbSize(), 665, 'thumb is heavily compressed');
203203

204204
// when scrolled past top by 200
205205
this.simulateCallback(true, -200);
206206
assert.equal(thumbPosition(), 0, 'thumb is at top');
207-
assert.equal(thumbSize(), 663, 'thumb is heavily compressed');
207+
assert.equal(thumbSize(), 665, 'thumb is heavily compressed');
208208
});
209209

210210
test('behavior when content is a lot more than scrollview height', async function(assert) {
@@ -216,37 +216,37 @@ module('Integration | Component | vertical-scroll-bar', function(hooks) {
216216
// when scrolled past bottom by 5
217217
this.simulateCallback(true, 1505);
218218
assert.equal(thumbPosition(), 376, 'thumb is at bottom');
219-
assert.equal(thumbSize(), 124, 'thumb is slightly compressed');
219+
assert.equal(thumbSize(), 126, 'thumb is slightly compressed');
220220

221221
// when scrolled past top by 5
222222
this.simulateCallback(true, -5);
223223
assert.equal(thumbPosition(), 0, 'thumb is at top');
224-
assert.equal(thumbSize(), 124, 'thumb is slightly compressed');
224+
assert.equal(thumbSize(), 126, 'thumb is slightly compressed');
225225

226226
// when scrolled to center
227227
this.simulateCallback(true, 750);
228228
assert.equal(thumbPosition(), 187, 'thumb is in center');
229-
assert.equal(thumbSize(), 126, 'thumb height is not compressed');
229+
assert.equal(thumbSize(), 127, 'thumb height is not compressed');
230230

231231
// when scrolled past bottom by 100
232232
this.simulateCallback(true, 1600);
233233
assert.equal(thumbPosition(), 395, 'thumb is at bottom');
234-
assert.equal(thumbSize(), 105, 'thumb is heavily compressed');
234+
assert.equal(thumbSize(), 106, 'thumb is heavily compressed');
235235

236236
// when scrolled past top by 100
237237
this.simulateCallback(true, -100);
238238
assert.equal(thumbPosition(), 0, 'thumb is at top');
239-
assert.equal(thumbSize(), 105, 'thumb is heavily compressed');
239+
assert.equal(thumbSize(), 106, 'thumb is heavily compressed');
240240

241241
// when scrolled past bottom by 500
242242
this.simulateCallback(true, 2000);
243243
assert.equal(thumbPosition(), 437, 'thumb is at bottom');
244-
assert.equal(thumbSize(), 63, 'thumb is small');
244+
assert.equal(thumbSize(), 65, 'thumb is small');
245245

246246
// when scrolled past top by 500
247247
this.simulateCallback(true, -500);
248248
assert.equal(thumbPosition(), 0, 'thumb is at top');
249-
assert.equal(thumbSize(), 63, 'thumb is small');
249+
assert.equal(thumbSize(), 65, 'thumb is small');
250250
});
251251

252252
test('calculations update when scrollerHeight changes', async function(assert) {
@@ -257,12 +257,12 @@ module('Integration | Component | vertical-scroll-bar', function(hooks) {
257257

258258
this.simulateCallback(true, 750);
259259
assert.equal(thumbPosition(), 187, 'thumb is in center');
260-
assert.equal(thumbSize(), 126, 'thumb height is not compressed');
260+
assert.equal(thumbSize(), 127, 'thumb height is not compressed');
261261

262262
this.set('scrollerHeight', 1000);
263263

264264
this.simulateCallback(true, 750);
265265
assert.equal(thumbPosition(), 375, 'thumb is in center');
266-
assert.equal(thumbSize(), 501, 'thumb height is not compressed');
266+
assert.equal(thumbSize(), 502, 'thumb height is not compressed');
267267
});
268268
});

0 commit comments

Comments
 (0)