Minor improvements#4
Closed
hrueger wants to merge 8 commits into
Closed
Conversation
cors headers needed for `SharedArrayBuffer`
Owner
|
Thanks a lot for this @hrueger, and sorry for the long delay! 🙏 Since this was opened the repo has moved on quite a bit (GPS metadata, thumbnail unpacking, improved TypeScript defs, a LibRaw 0.22.1 rebuild), so the directory restructure / submodule build here now conflicts heavily and largely overlaps with work that landed in the meantime. Rather than let the good parts get lost, I've reimplemented your most valuable addition — the Closing this in favor of #16. Really appreciate the contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ybouane,
thanks for this very cool library! I'm working on a Camera Characterization Tool for University and this perfectly fits for loading the raw files 🎉
I did have some improvements, feel free to pick what you like:
rawImageDatafunction to get raw, undebayered sensor data (sorry for the typo in the commit message)librawlib and improves the build speedI should still add some docs to the readme about the changes in the build process, I think, like initing submodules with
git submodule update --init