pkg/model: Fix title sorting.

Author: yifan-gu

pkg/model/book.go

@@ -78,26 +78,10 @@ func ValidateMark(m *Mark) error {
 	return nil
 }
 
-// ByTitle is a type that implements sort.Interface for []*Book based on the Title field.
-type ByTitle []*Book
-
-// Len is the number of elements in the collection.
-func (b ByTitle) Len() int {
-	return len(b)
-}
-
-// Less reports whether the element at index i should sort before the element at index j.
-func (b ByTitle) Less(i, j int) bool {
-	// Compare titles case-insensitively
-	return strings.ToLower(b[i].Title) < strings.ToLower(b[j].Title)
-}
-
-// Swap swaps the elements at indexes i and j.
-func (b ByTitle) Swap(i, j int) {
-	b[i], b[j] = b[j], b[i]
-}
-
-// SortBooksByTitle sorts a slice of books by title.
 func SortBooksByTitle(books []*Book) {
-	sort.Sort(ByTitle(books))
+	sort.Slice(books, func(i, j int) bool {
+		titleA := strings.ToLower(books[i].Title)
+		titleB := strings.ToLower(books[j].Title)
+		return titleA < titleB
+	})
 }

pkg/parser/kindlemyclippings/parser.go

@@ -159,6 +159,9 @@ func (p *KindleMyClippingsParser) Parse(inputPath string) ([]*model.Book, error)
 	// Final summary
 	fmt.Fprintln(os.Stderr) // Add a newline after the progress output
 	fmt.Fprintf(os.Stderr, "Finished processing: %d lines parsed, %d books deduplicated, %d marks processed\n", lineCount, totalBooks, entryCount)
+
+	model.SortBooksByTitle(books)
+
 	return books, nil
 }
 

tests/my_clippings_output.json

@@ -55,42 +55,6 @@
       }
     ]
   },
-  {
-    "title": "红楼梦（人文社权威定本彩皮版；国务院文化组批准，红研所校注；豆瓣读书TOP250首位，评论上万条；出版四十年，三次修订）",
-    "author": "曹雪芹",
-    "marks": [
-      {
-        "type": "HIGHLIGHT",
-        "title": "红楼梦（人文社权威定本彩皮版；国务院文化组批准，红研所校注；豆瓣读书TOP250首位，评论上万条；出版四十年，三次修订）",
-        "author": "曹雪芹",
-        "location": {
-          "location": 15868
-        },
-        "data": "都是尤二姐素习所穿的，不禁又伤心哭了起来。自己用个包袱一齐包了，也不命小厮丫鬟来拿，便自己提着来烧。",
-        "createdAt": 1642265828
-      },
-      {
-        "type": "HIGHLIGHT",
-        "title": "红楼梦（人文社权威定本彩皮版；国务院文化组批准，红研所校注；豆瓣读书TOP250首位，评论上万条；出版四十年，三次修订）",
-        "author": "曹雪芹",
-        "location": {
-          "location": 15869
-        },
-        "data": "平儿又是伤心，又是好笑，忙将二百两一包的碎银子偷了出来，",
-        "createdAt": 1642265863
-      },
-      {
-        "type": "HIGHLIGHT",
-        "title": "红楼梦（人文社权威定本彩皮版；国务院文化组批准，红研所校注；豆瓣读书TOP250首位，评论上万条；出版四十年，三次修订）",
-        "author": "曹雪芹",
-        "location": {
-          "location": 15871
-        },
-        "data": "又将一条裙子递与平儿，说：“这是他家常穿的，你好生替我收着，作个念心儿。”",
-        "createdAt": 1642265884
-      }
-    ]
-  },
   {
     "title": "小行星掉在下午（首届宝珀理想国文学奖决选作者沈大成全新小说集，给沈大成6分钟，她给你一场颅内反乌托邦式冒险 理想国出品）",
     "author": "沈大成",
@@ -129,5 +93,41 @@
         "createdAt": 1642641563
       }
     ]
+  },
+  {
+    "title": "红楼梦（人文社权威定本彩皮版；国务院文化组批准，红研所校注；豆瓣读书TOP250首位，评论上万条；出版四十年，三次修订）",
+    "author": "曹雪芹",
+    "marks": [
+      {
+        "type": "HIGHLIGHT",
+        "title": "红楼梦（人文社权威定本彩皮版；国务院文化组批准，红研所校注；豆瓣读书TOP250首位，评论上万条；出版四十年，三次修订）",
+        "author": "曹雪芹",
+        "location": {
+          "location": 15868
+        },
+        "data": "都是尤二姐素习所穿的，不禁又伤心哭了起来。自己用个包袱一齐包了，也不命小厮丫鬟来拿，便自己提着来烧。",
+        "createdAt": 1642265828
+      },
+      {
+        "type": "HIGHLIGHT",
+        "title": "红楼梦（人文社权威定本彩皮版；国务院文化组批准，红研所校注；豆瓣读书TOP250首位，评论上万条；出版四十年，三次修订）",
+        "author": "曹雪芹",
+        "location": {
+          "location": 15869
+        },
+        "data": "平儿又是伤心，又是好笑，忙将二百两一包的碎银子偷了出来，",
+        "createdAt": 1642265863
+      },
+      {
+        "type": "HIGHLIGHT",
+        "title": "红楼梦（人文社权威定本彩皮版；国务院文化组批准，红研所校注；豆瓣读书TOP250首位，评论上万条；出版四十年，三次修订）",
+        "author": "曹雪芹",
+        "location": {
+          "location": 15871
+        },
+        "data": "又将一条裙子递与平儿，说：“这是他家常穿的，你好生替我收着，作个念心儿。”",
+        "createdAt": 1642265884
+      }
+    ]
   }
 ]