Fix comparison in BaseHtml::renderSelectOptions()
#19580
WinterSilence
started this conversation in
Polls
Replies: 1 comment
-
string keys would be perfect for me! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Current behavior of BaseHtml::renderSelectOptions() is incorrect:
$selection
and$key
to strings$selection
and$key
as strings at strict comparation$key
) with object($selection
)As result, in some cases method return invalid value or throw error.
I'm created 2 PR's:
BaseHtml::renderSelectOptions()
#19577 Complete, but breaks BCBaseHtml::renderSelectOptions()
#19579 Fix only error at non-stict comparation8 votes ·
Beta Was this translation helpful? Give feedback.
All reactions