Skip to content

Commit 648bd1f

Browse files
authored
bug: git tag -f needs moved, add permissions to publish workflows (getporter#2985)
* bug: git tag -f needs moved, add permissions to publish workflows Signed-off-by: Sarah Christoff <[email protected]> --------- Signed-off-by: Sarah Christoff <[email protected]>
1 parent 9b611b8 commit 648bd1f

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.github/workflows/build_pipelinesrelease_template.yml

+2
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ jobs:
128128
- Validate-integration_test
129129
- Validate-smoke_test
130130
runs-on: ubuntu-latest
131+
permissions: write-all
131132
if: success() && inputs.shouldPublish
132133
steps:
133134
- name: checkout
@@ -161,6 +162,7 @@ jobs:
161162
- Validate-integration_test
162163
- Validate-smoke_test
163164
runs-on: ubuntu-latest
165+
permissions: write-all
164166
if: success() && inputs.shouldPublish
165167
steps:
166168
- name: checkout

magefile.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -487,7 +487,7 @@ func PublishPorter() {
487487
// Create or update GitHub release for the permalink (canary/latest) with the version's assets (porter binaries, exec binaries and install scripts)
488488
if info.ShouldPublishPermalink() {
489489
// Move the permalink tag. The existing release automatically points to the tag.
490-
must.RunV("git", "tag", info.Permalink, info.Version+"-f")
490+
must.RunV("git", "tag", "-f", info.Permalink, info.Version)
491491
must.RunV("git", "push", "-f", remote, info.Permalink)
492492

493493
releases.AddFilesToRelease(repo, info.Permalink, porterVersionDir)

0 commit comments

Comments
 (0)