Skip to content

Commit cd9625f

Browse files
committed
Merge pull request #13 from yllieth/fix-event_emitter
Fix event emitter
2 parents b26b937 + 7567890 commit cd9625f

File tree

6 files changed

+10
-8
lines changed

6 files changed

+10
-8
lines changed

bower.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "predicsis_ml_sdk-javascript",
3-
"version": "0.2.3",
3+
"version": "0.2.4",
44
"authors": [
55
"Yllieth <[email protected]>",
66
"Dehau"
@@ -37,4 +37,4 @@
3737
"devDependencies": {
3838
"angular-mocks": "~1.3.15"
3939
}
40-
}
40+
}

dist/predicsis-jsSDK.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3376,7 +3376,8 @@ angular
33763376
emitter.emit('cancelled', datasetId);
33773377
}
33783378
};
3379-
emitter.emit('started', dataset);
3379+
// Give a chance to potential subscribers to catch first event (started)
3380+
setTimeout(emitter.emit.bind(emitter, 'started', dataset), 0);
33803381
Upload.getCredentials('s3')
33813382
.then(function(credential) {
33823383
var form = createForm(credential, file);

dist/predicsis-jsSDK.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/predicsis-jsSDK.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/helper/s3FileHelper.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ angular
8282
emitter.emit('cancelled', datasetId);
8383
}
8484
};
85-
emitter.emit('started', dataset);
85+
// Give a chance to potential subscribers to catch first event (started)
86+
setTimeout(emitter.emit.bind(emitter, 'started', dataset), 0);
8687
Upload.getCredentials('s3')
8788
.then(function(credential) {
8889
var form = createForm(credential, file);

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "predicsis_ml_sdk-javascript",
3-
"version": "0.2.3",
3+
"version": "0.2.4",
44
"description": "Javascript SDK for PredicSis ML API",
55
"main": "index.js",
66
"scripts": {
@@ -41,4 +41,4 @@
4141
"load-grunt-tasks": "^3.1.0",
4242
"phantomjs": "^1.9.16"
4343
}
44-
}
44+
}

0 commit comments

Comments
 (0)