Let PHPStan check array and iterable types & generics (#27)

Author: yann-eugone

src/CommandRunner.php

@@ -35,18 +35,15 @@ public function __construct(string $binDir, string $logDir, PhpExecutableFinder
     }
 
     /**
-     * @param string $commandName
-     * @param array  $arguments
+     * @phpstan-param array<string, mixed> $arguments
      */
     public function run(string $commandName, array $arguments = []): void
     {
         $this->exec($this->buildCommand($commandName, $arguments));
     }
 
     /**
-     * @param string $commandName
-     * @param string $logFilename
-     * @param array  $arguments
+     * @phpstan-param array<string, mixed> $arguments
      */
     public function runAsync(string $commandName, string $logFilename, array $arguments = []): void
     {
@@ -64,6 +61,9 @@ protected function exec(string $command): void
         exec($command);
     }
 
+    /**
+     * @phpstan-param array<string, mixed> $arguments
+     */
     private function buildCommand(string $commandName, array $arguments): string
     {
         return sprintf(

src/RunJobCommand.php

@@ -15,6 +15,8 @@
 
 final class RunJobCommand extends Command
 {
+    protected static $defaultName = 'yokai:batch:run';
+
     public const EXIT_SUCCESS_CODE = 0;
     public const EXIT_ERROR_CODE = 1;
     public const EXIT_WARNING_CODE = 2;
@@ -29,7 +31,7 @@ final class RunJobCommand extends Command
      */
     public function __construct(JobLauncherInterface $jobLauncher)
     {
-        parent::__construct(null);
+        parent::__construct();
         $this->jobLauncher = $jobLauncher;
     }
 
@@ -38,10 +40,8 @@ public function __construct(JobLauncherInterface $jobLauncher)
      */
     protected function configure(): void
     {
-        $this
-            ->setName('yokai:batch:run')
-            ->addArgument('job', InputArgument::REQUIRED)
-            ->addArgument('configuration', InputArgument::OPTIONAL);
+        $this->addArgument('job', InputArgument::REQUIRED);
+        $this->addArgument('configuration', InputArgument::OPTIONAL);
     }
 
     /**
@@ -118,6 +118,8 @@ private function outputExecution(JobExecution $jobExecution, OutputInterface $ou
      *
      * @throws InvalidArgumentException
      * @return array
+     *
+     * @phpstan-return array<string, mixed>
      */
     private function decodeConfiguration(string $data): array
     {