Skip to content

Fix order handling #3112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 17, 2025
Merged

Fix order handling #3112

merged 8 commits into from
Jul 17, 2025

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Jun 3, 2025

This is many fixes to how 'order' is handled. See the changelong entries for details of bugs fixed.

Fixes #2948, and helps with #3072.

@dstansby dstansby marked this pull request as draft June 6, 2025 12:36
@dstansby dstansby force-pushed the order-handling branch 2 times, most recently from 4b9ca56 to c8a1652 Compare June 7, 2025 12:20
@dstansby dstansby changed the base branch from main to 3.0.x June 17, 2025 09:20
@dstansby dstansby marked this pull request as ready for review June 17, 2025 09:21
@dstansby dstansby changed the base branch from 3.0.x to main June 20, 2025 08:30
@dstansby dstansby requested a review from a team July 6, 2025 20:20
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.57%. Comparing base (7a162bf) to head (6a55eae).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/zarr/api/asynchronous.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3112      +/-   ##
==========================================
- Coverage   59.58%   59.57%   -0.01%     
==========================================
  Files          78       78              
  Lines        8694     8686       -8     
==========================================
- Hits         5180     5175       -5     
+ Misses       3514     3511       -3     
Files with missing lines Coverage Δ
src/zarr/core/array.py 69.02% <100.00%> (ø)
src/zarr/core/group.py 69.33% <ø> (ø)
src/zarr/api/asynchronous.py 70.27% <66.66%> (+0.20%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dstansby dstansby added this to the 3.1.1 milestone Jul 15, 2025
@dstansby dstansby requested review from d-v-b and joshmoore July 16, 2025 15:33
@d-v-b
Copy link
Contributor

d-v-b commented Jul 16, 2025

this looks good other than the text of the warning that claims that zarr v3 arrays are always stored in C order. That text needs to be made more precise.

@dstansby dstansby requested a review from d-v-b July 17, 2025 10:09
@d-v-b d-v-b enabled auto-merge (squash) July 17, 2025 21:52
@d-v-b d-v-b merged commit df40f4f into zarr-developers:main Jul 17, 2025
30 checks passed
@dstansby dstansby deleted the order-handling branch July 18, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect warning when creating zarr_format=2 array with order keyword
3 participants