WIP

Author: daira

.github/workflows/ci.yml

@@ -66,16 +66,19 @@ jobs:
         run: cargo add --no-default-features --features "circuit" --path ../crate_root
       - name: Add lazy_static with the spin_no_std feature
         working-directory: ./ci-build
-        run: cargo add lazy_static --features "spin_no_std"
+        run: cargo add lazy_static --no-default-features --features "spin_no_std"
       - name: Add typenum with the no_std feature
         working-directory: ./ci-build
-        run: cargo add typenum --features "no_std"
+        run: cargo add typenum --no-default-features --features "no_std"
       - name: Show Cargo.toml for the synthetic crate
         working-directory: ./ci-build
         run: cat Cargo.toml
-      - name: XXX DEBUG
+      - name: DEBUG cargo tree -i -p getrandom -e features
         working-directory: ./ci-build
         run: cargo tree -i -p getrandom -e features
+      - name: DEBUG cargo tree -i -p rand_core -e features
+        working-directory: ./ci-build
+        run: cargo tree -i -p rand_core -e features
       - name: Add target
         working-directory: ./ci-build
         run: rustup target add ${{ matrix.target }}

.github/workflows/lints-stable.yml

@@ -46,13 +46,19 @@ jobs:
         run: cargo add --no-default-features --features "circuit" --path ../crate_root
       - name: Add lazy_static with the spin_no_std feature
         working-directory: ./ci-build
-        run: cargo add lazy_static --features "spin_no_std"
+        run: cargo add lazy_static --no-default-features --features "spin_no_std"
       - name: Add typenum with the no_std feature
         working-directory: ./ci-build
-        run: cargo add typenum --features "no_std"
+        run: cargo add typenum --no-default-features --features "no_std"
       - name: Show Cargo.toml for the synthetic crate
         working-directory: ./ci-build
         run: cat Cargo.toml
+      - name: DEBUG cargo tree -i -p getrandom -e features
+        working-directory: ./ci-build
+        run: cargo tree -i -p getrandom -e features
+      - name: DEBUG cargo tree -i -p rand_core -e features
+        working-directory: ./ci-build
+        run: cargo tree -i -p rand_core -e features
       - name: Add target
         working-directory: ./ci-build
         run: rustup target add ${{ matrix.target }}

CHANGELOG.md

@@ -6,6 +6,11 @@ and this project adheres to Rust's notion of
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- The "circuit" feature no longer implies the "std" feature. "circuit" can now
+  potentially be used in `no_std` environments.
+- `orchard::bundle::batch` is now only available when the "std" feature is enabled
+  together with the "circuit" feature.
 
 ## [0.11.0] - 2025-02-20
 

Cargo.lock

@@ -48,7 +48,7 @@ zip32 = { version = "0.2.0", default-features = false }
 visibility = "0.1.1"
 
 # Circuit
-halo2_gadgets = { version = "0.3", optional = true }
+halo2_gadgets = { version = "0.3", optional = true, default-features = false }
 halo2_proofs = { version = "0.3", optional = true, default-features = false, features = ["batch", "floor-planner-v1-legacy-pdqsort"] }
 
 # Boilerplate
@@ -87,7 +87,7 @@ circuit = ["dep:halo2_gadgets", "dep:halo2_proofs"]
 unstable-frost = []
 multicore = ["halo2_proofs?/multicore"]
 dev-graph = ["halo2_proofs?/dev-graph", "image", "plotters"]
-test-dependencies = ["proptest"]
+test-dependencies = ["proptest", "rand/std"]
 
 [[bench]]
 name = "note_decryption"
@@ -106,3 +106,7 @@ debug = true
 
 [profile.bench]
 debug = true
+
+[patch.crates-io]
+halo2_gadgets = { git = "https://github.com/zcash/halo2.git", rev = "7e173f8e2e6e8717052e472384bdf28e58eaff19" }
+halo2_proofs = { git = "https://github.com/zcash/halo2.git", rev = "7e173f8e2e6e8717052e472384bdf28e58eaff19" }