More cleanup and coverage

Author: STRd6

main.coffee

@@ -122,12 +122,6 @@ module.exports = Observable = (value, context) ->
 
     # Extra methods for array observables
     extend self,
-      each: (callback) ->
-        self.forEach (item, index) ->
-          callback.call(item, item, index, self)
-
-        return self
-
       # Remove an element from the array and notify observers of changes.
       remove: (object) ->
         index = value.indexOf(object)
@@ -200,16 +194,6 @@ tryCallWithFinallyPop = (observableDependencies, fn, context) ->
     global.OBSERVABLE_ROOT_HACK.pop()
 
 
-# Check if we can proxy function length property.
-try
-  Object.defineProperty (->), 'length',
-    get: ->
-    set: ->
-
-  PROXY_LENGTH = true
-catch
-  PROXY_LENGTH = false
-
 remove = (array, value) ->
   index = array.indexOf(value)
 
@@ -222,9 +206,14 @@ copy = (array) ->
 last = (array) ->
   array[array.length - 1]
 
-flatten = (array) ->
-  array.reduce (a, b) ->
-    a.concat(b)
-  , []
-
 noop = ->
+
+# Check if we can proxy function length property.
+try
+  Object.defineProperty (->), 'length',
+    get: noop
+    set: noop
+
+  PROXY_LENGTH = true
+catch
+  PROXY_LENGTH = false

test/observable.coffee

@@ -30,6 +30,10 @@ describe 'Observable', ->
 
     assert.equal o, Observable(o)
 
+  it "should have releaseDependencies as a noop because primitive observables don't have any dependencies", ->
+    o = Observable(5)
+    o.releaseDependencies()
+
   it "should allow for stopping observation", ->
     observable = Observable("string")
 
@@ -48,6 +52,10 @@ describe 'Observable', ->
 
     assert.equal called, 1
 
+  it "should do nothing when removing a listener that's not present", ->
+    observable = Observable("string")
+    observable.stopObserving ->
+
   it "should increment", ->
     observable = Observable 1
 
@@ -120,16 +128,13 @@ describe "Observable Array", ->
 
     assert.equal o.last(), 3
 
-  it "#remove", (done) ->
+  it "#remove", ->
     o = Observable [0, 1, 2, 3]
 
-    o.observe (newValue) ->
-      assert.equal newValue.length, 3
-      setTimeout ->
-        done()
-      , 0
-
     assert.equal o.remove(2), 2
+    assert.equal o.length, 3
+    assert.equal o.remove(-5), undefined
+    assert.equal o.length, 3
 
   it "#remove non-existent element", ->
     o = Observable [1, 2, 3]
@@ -393,19 +398,18 @@ describe "Observable functions", ->
 
     assert.equal o(), "wat"
 
-  describe "Scoping", ->
-    it "should be scoped to optional context", (done) ->
-      model =
-        firstName: Observable "Duder"
-        lastName: Observable "Man"
+  it "should be scoped to optional context", (done) ->
+    model =
+      firstName: Observable "Duder"
+      lastName: Observable "Man"
 
-      model.name = Observable ->
-        "#{@firstName()} #{@lastName()}"
-      , model
+    model.name = Observable ->
+      "#{@firstName()} #{@lastName()}"
+    , model
 
-      model.name.observe (newValue) ->
-        assert.equal newValue, "Duder Bro"
+    model.name.observe (newValue) ->
+      assert.equal newValue, "Duder Bro"
 
-        done()
+      done()
 
-      model.lastName "Bro"
+    model.lastName "Bro"