Skip to content

refactor: migrate to tailwind 4 #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

JosueGalRe
Copy link
Member

@JosueGalRe JosueGalRe commented Jun 18, 2025

note: per file/component style tag with @/apply tags can be done but could cause issues and will force tw to process stylesheets multiple times, because now to use @/apply you need to @/reference tw in the style tag you will use it, as per this, i have moved all classes into a single file, we can re arrange into other ways, but wouldn't recommend to use style tags again unless necessary.

@JosueGalRe JosueGalRe self-assigned this Jun 18, 2025
@JosueGalRe JosueGalRe added the enhancement New feature or request label Jun 18, 2025
Copy link
Member

@Raiden0456 Raiden0456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked all pages with <style> tags in them? although new approach looks ok, we have to be double check all the places

@JosueGalRe
Copy link
Member Author

Have you checked all pages with <style> tags in them? although new approach looks ok, we have to be double check all the places

Most (I think all) of them were components and they look good, but feel free to do a side by side comparison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants