chore(core): eslint config updates

Author: polonel

.eslintrc.json

@@ -13,7 +13,8 @@
   },
   "rules": {
     "standard/no-callback-literal": 0, // enable after error handing refactor
-    "node/exports-style": ["error", "module.exports"],
+    "node/exports-style": 0,
+    "n/no-callback-literal": 0,
     "new-cap": 0,
     "no-console": "off",
     "complexity": ["error", 20]

src/client/.eslintrc.json

@@ -16,7 +16,8 @@
   },
   "extends": ["eslint:recommended", "plugin:react/recommended", "plugin:import/errors", "plugin:import/warnings"],
   "rules": {
-    "node/no-unsupported-features/es-syntax": 0
+    "node/no-unsupported-features/es-syntax": 0,
+    "node/exports-style": 0
   },
   "settings": {
     "import/resolver": ["node", "webpack"]

src/permissions/index.js

@@ -12,12 +12,12 @@
  *  Copyright (c) 2014-2019. All rights reserved.
  */
 
-var _ = require('lodash')
-var winston = require('../logger')
-var roleSchema = require('../models/role')
-var roleOrder = require('../models/roleorder')
+const _ = require('lodash')
+const winston = require('../logger')
+const roleSchema = require('../models/role')
+const roleOrder = require('../models/roleorder')
 
-var register = function (callback) {
+const register = function (callback) {
   // Register Roles
   roleSchema.getRolesLean(function (err, roles) {
     if (err) return callback(err)
@@ -42,23 +42,23 @@ var register = function (callback) {
  * @returns {boolean}
  */
 
-var canThis = function (role, a, adminOverride = false) {
+const canThis = function (role, a, adminOverride = false) {
   if (_.isUndefined(role)) return false
   if (adminOverride === true && role.isAdmin) return true
 
-  var roles = global.roles
+  const roles = global.roles
   if (_.isUndefined(roles)) return false
   if (_.hasIn(role, '_id')) role = role._id
-  var rolePerm = _.find(roles, { _id: role })
+  const rolePerm = _.find(roles, { _id: role })
   if (_.isUndefined(rolePerm)) return false
   if (_.indexOf(rolePerm.grants, '*') !== -1) return true
 
-  var actionType = a.split(':')[0]
-  var action = a.split(':')[1]
+  const actionType = a.split(':')[0]
+  const action = a.split(':')[1]
 
   if (_.isUndefined(actionType) || _.isUndefined(action)) return false
 
-  var result = _.filter(rolePerm.grants, function (value) {
+  const result = _.filter(rolePerm.grants, function (value) {
     if (_.startsWith(value, actionType + ':')) return value
   })
 
@@ -67,32 +67,32 @@ var canThis = function (role, a, adminOverride = false) {
     if (result[0] === '*') return true
   }
 
-  var typePerm = result[0].split(':')[1].split(' ')
+  let typePerm = result[0].split(':')[1].split(' ')
   typePerm = _.uniq(typePerm)
 
   if (_.indexOf(typePerm, '*') !== -1) return true
 
   return _.indexOf(typePerm, action) !== -1
 }
 
-var getRoles = function (action) {
+const getRoles = function (action) {
   if (_.isUndefined(action)) return false
 
-  var rolesWithAction = []
-  var roles = global.roles
+  let rolesWithAction = []
+  const roles = global.roles
   if (_.isUndefined(roles)) return []
 
   _.each(roles, function (role) {
-    var actionType = action.split(':')[0]
-    var theAction = action.split(':')[1]
+    const actionType = action.split(':')[0]
+    const theAction = action.split(':')[1]
 
     if (_.isUndefined(actionType) || _.isUndefined(theAction)) return
     if (_.indexOf(role.grants, '*') !== -1) {
       rolesWithAction.push(role)
       return
     }
 
-    var result = _.filter(role.grants, function (value) {
+    const result = _.filter(role.grants, function (value) {
       if (_.startsWith(value, actionType + ':')) return value
     })
 
@@ -104,7 +104,7 @@ var getRoles = function (action) {
       }
     }
 
-    var typePerm = result[0].split(':')[1].split(' ')
+    let typePerm = result[0].split(':')[1].split(' ')
     typePerm = _.uniq(typePerm)
 
     if (_.indexOf(typePerm, '*') !== -1) {
@@ -123,17 +123,17 @@ var getRoles = function (action) {
 }
 
 function hasHierarchyEnabled (roleId) {
-  var role = _.find(global.roles, function (o) {
+  const role = _.find(global.roles, function (o) {
     return o._id.toString() === roleId.toString()
   })
   if (_.isUndefined(role) || _.isUndefined(role.hierarchy)) return true
   return role.hierarchy
 }
 
 function parseRoleHierarchy (roleId) {
-  var roleOrder = global.roleOrder.order
+  const roleOrder = global.roleOrder.order
 
-  var idx = _.findIndex(roleOrder, function (i) {
+  const idx = _.findIndex(roleOrder, function (i) {
     return i.toString() === roleId.toString()
   })
   if (idx === -1) return []
@@ -142,9 +142,9 @@ function parseRoleHierarchy (roleId) {
 }
 
 function hasPermOverRole (ownRole, extRole) {
-  var roles = parseRoleHierarchy(extRole)
+  const roles = parseRoleHierarchy(extRole)
 
-  var i = _.find(roles, function (o) {
+  const i = _.find(roles, function (o) {
     return o.toString() === ownRole.toString()
   })
 
@@ -160,9 +160,9 @@ function isAdmin (roleId, callback) {
 }
 
 function isAdminSync (roleId) {
-  var roles = global.roles
+  const roles = global.roles
   if (!roles) return false
-  var role = _.find(roles, function (r) {
+  const role = _.find(roles, function (r) {
     return r._id.toString() === roleId.toString()
   })
 
@@ -178,15 +178,15 @@ function buildGrants (obj) {
 }
 
 module.exports = {
-  register: register,
+  register,
   flushRoles: register,
-  canThis: canThis,
-  hasHierarchyEnabled: hasHierarchyEnabled,
-  parseRoleHierarchy: parseRoleHierarchy,
-  hasPermOverRole: hasPermOverRole,
-
-  getRoles: getRoles,
-  isAdmin: isAdmin,
-  isAdminSync: isAdminSync,
-  buildGrants: buildGrants
+  canThis,
+  hasHierarchyEnabled,
+  parseRoleHierarchy,
+  hasPermOverRole,
+
+  getRoles,
+  isAdmin,
+  isAdminSync,
+  buildGrants
 }