Skip to content

Commit a5a5911

Browse files
committed
fixes the screen reader issues in the single ticket page
1 parent bd62dfb commit a5a5911

File tree

4 files changed

+21
-11
lines changed

4 files changed

+21
-11
lines changed

public/js/5.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

public/js/5.js.gz

125 Bytes
Binary file not shown.

src/client/containers/Messages/index.jsx

+2
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,7 @@ class MessagesContainer extends React.Component {
317317
<div id='convo-actions' style={{ position: 'absolute', top: 20, right: 15 }}>
318318
{!this.userListShown && (
319319
<a
320+
href='#'
320321
title='Start Conversation'
321322
className='no-ajaxy'
322323
style={{ display: 'block', height: 28 }}
@@ -329,6 +330,7 @@ class MessagesContainer extends React.Component {
329330
)}
330331
{this.userListShown && (
331332
<a
333+
href='#'
332334
className='no-ajaxy'
333335
style={{ height: 28, lineHeight: '30px', fontSize: '16px', fontWeight: 300 }}
334336
onClick={e => this.hideUserList(e)}

src/client/containers/Tickets/SingleTicketContainer.jsx

+17-9
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,13 @@ class SingleTicketContainer extends React.Component {
289289
}
290290

291291
return (
292-
<div className={'uk-clearfix uk-position-relative'} style={{ width: '100%', height: '100vh' }}>
292+
<div
293+
className={'uk-clearfix uk-position-relative'}
294+
style={{ width: '100%', height: '100vh' }}
295+
role="main"
296+
aria-label="Ticket Details"
297+
tabIndex="0"
298+
>
293299
{!this.ticket && <SpinLoader active={true} />}
294300
{this.ticket && (
295301
<Fragment>
@@ -299,7 +305,7 @@ class SingleTicketContainer extends React.Component {
299305
style={{ width: 360, maxWidth: 360, minWidth: 360 }}
300306
>
301307
<div className='page-title-border-right relative' style={{ padding: '0 30px' }}>
302-
<p>Ticket #{this.ticket.uid}</p>
308+
<h1>Ticket #{this.ticket.uid}</h1>
303309
<StatusSelector
304310
ticketId={this.ticket._id}
305311
status={this.ticket.status._id}
@@ -311,10 +317,10 @@ class SingleTicketContainer extends React.Component {
311317
/>
312318
</div>
313319
{/* Left Side */}
314-
<div className='page-content-left full-height scrollable'>
320+
<div className='page-content-left full-height scrollable' role="complementary" aria-label="Ticket Information">
315321
<div className='ticket-details-wrap uk-position-relative uk-clearfix'>
316322
<div className='ticket-assignee-wrap uk-clearfix' style={{ paddingRight: 30 }}>
317-
<h4>Assignee</h4>
323+
<h2>Assignee</h2>
318324
<div className='ticket-assignee uk-clearfix'>
319325
{hasTicketUpdate && (
320326
<a
@@ -370,10 +376,11 @@ class SingleTicketContainer extends React.Component {
370376

371377
<div className='uk-width-1-1 padding-left-right-15'>
372378
<div className='tru-card ticket-details uk-clearfix'>
379+
<h3>Ticket Details</h3>
373380
{/* Type */}
374381
<div className='uk-width-1-2 uk-float-left nopadding'>
375382
<div className='marginright5'>
376-
<span>Type</span>
383+
<label htmlFor="ticketType">Type</label>
377384
{hasTicketUpdate && (
378385
<select
379386
value={this.ticket.type._id}
@@ -415,7 +422,7 @@ class SingleTicketContainer extends React.Component {
415422
{/* Priority */}
416423
<div className='uk-width-1-2 uk-float-left nopadding'>
417424
<div className='marginleft5'>
418-
<span>Priority</span>
425+
<label htmlFor="ticketPriority">Priority</label>
419426
{hasTicketUpdate && (
420427
<select
421428
name='tPriority'
@@ -542,7 +549,7 @@ class SingleTicketContainer extends React.Component {
542549
{helpers.canUser('agent:*', true) && (
543550
<div className='uk-width-1-1 padding-left-right-15'>
544551
<div className='tru-card ticket-details pr-0 pb-0' style={{ height: 250 }}>
545-
Ticket History
552+
<h3>Ticket History</h3>
546553
<hr style={{ padding: 0, margin: 0 }} />
547554
<div className='history-items scrollable' style={{ paddingTop: 12 }}>
548555
{this.ticket.history &&
@@ -565,7 +572,7 @@ class SingleTicketContainer extends React.Component {
565572
</div>
566573
</div>
567574
{/* Right Side */}
568-
<div className='page-message nopadding' style={{ marginLeft: 360 }}>
575+
<div className='page-message nopadding' style={{ marginLeft: 360 }} role="region" aria-label="Ticket Comments and Notes">
569576
<div className='page-title-right noshadow'>
570577
{this.props.common.get('hasThirdParty') && (
571578
<div className='page-top-comments uk-float-right'>
@@ -861,6 +868,7 @@ class SingleTicketContainer extends React.Component {
861868
</div>
862869
</div>
863870
</div>
871+
<div aria-live="polite" id="ticket-updates" className="sr-only"></div>
864872
<OffCanvasEditor primaryLabel={'Save Edit'} ref={r => (this.editorWindow = r)} />
865873
</Fragment>
866874
)}
@@ -904,4 +912,4 @@ export default connect(mapStateToProps, {
904912
unloadGroups,
905913
showModal,
906914
transferToThirdParty
907-
})(SingleTicketContainer)
915+
})(SingleTicketContainer)

0 commit comments

Comments
 (0)