Skip to content

Commit b67c915

Browse files
committed
UI Fixes after Webpack migration.
1 parent 5c42053 commit b67c915

File tree

6 files changed

+27
-12
lines changed

6 files changed

+27
-12
lines changed

src/public/js/app.js

+6-4
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ require(['config', 'jquery', 'modules/helpers', 'angular', 'angularjs/main'], fu
2929
});
3030

3131
require([
32+
'underscore',
3233
'modules/navigation',
3334
'modules/enjoyhint',
3435
'uikit',
@@ -41,19 +42,20 @@ require(['config', 'jquery', 'modules/helpers', 'angular', 'angularjs/main'], fu
4142
'nicescroll',
4243
'easypiechart'
4344

44-
], function(nav, eh) {
45+
], function(_, nav, eh) {
4546
//Page loading (init)
4647
require(['pages/pageloader'], function(pl) { pl.init(); });
4748

4849
nav.init();
49-
setTimeout(function(){
5050

51+
var $event = _.debounce(function() {
5152
helpers.hideLoader(1000);
5253
helpers.countUpMe();
5354
helpers.UI.cardShow();
5455

5556
$.event.trigger('$trudesk:ready');
56-
}, 500);
57-
//eh.init();
57+
}, 100);
58+
59+
$event();
5860
});
5961
});

src/public/js/modules/ajaxify.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,15 @@
1414

1515
define('modules/ajaxify', [
1616
'jquery',
17+
'underscore',
1718
'angular',
1819
'modules/helpers',
1920
'modules/navigation',
2021
'pages/pageloader',
2122
'modules/socket',
2223
'history'
2324

24-
], function($, angular, helpers, nav, pageLoader, socketClient) {
25+
], function($, _, angular, helpers, nav, pageLoader, socketClient) {
2526

2627
$(window).on('statechangecomplete', function() {
2728
//Global
@@ -46,7 +47,11 @@ define('modules/ajaxify', [
4647
helpers.UI.cardShow();
4748
helpers.countUpMe();
4849

49-
$.event.trigger('$trudesk:ready');
50+
var event = _.debounce(function() {
51+
$.event.trigger('$trudesk:ready');
52+
}, 100);
53+
54+
event();
5055
});
5156

5257

src/public/js/modules/helpers.js

+2
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ function($, _, moment, UIkit, CountUp, Waves, Selectize, Snackbar, ROLES) {
4848
self.UI.matchHeight();
4949

5050
var layout = self.onWindowResize();
51+
//Initial Call to Load Layout
52+
layout();
5153
$(window).resize(layout);
5254
};
5355

src/public/js/pages/messages.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,10 @@ define('pages/messages', [
7777
$messageScrollerNS.doScrollTop($messageScroller.outerHeight() + 5000, 1000);
7878

7979
//set active
80-
$('ul > li[data-conversation-id="' + $convoId + '"]').addClass('active');
80+
if ($convoId !== undefined) {
81+
var item = $('ul > li[data-conversation-id="' + $convoId + '"]');
82+
item.addClass('active');
83+
}
8184

8285
//Remove All Chat Boxes
8386
if ($('#__page').text().toLowerCase() === 'messages') {

src/public/js/truRequire.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
//This gets loaded for accessing require from outside Webpack bundle.
22
var allMods = {
33
jquery: function() { return require('jquery'); },
4-
snackbar: function() { return require('snackbar'); }
4+
snackbar: function() { return require('snackbar'); },
5+
underscore: function() { return require('underscore'); }
56
};
67

78
module.exports = function (modules, cb) {

src/views/login-otp.hbs

+6-4
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,8 @@
152152
</style>
153153

154154
<script src="/socket.io/socket.io.js"></script>
155-
<script src="/js/vendor/requirejs/requirejs.min.js"></script>
155+
<script src="/js/vendor.js"></script>
156+
<script src="/js/truRequire.js"></script>
156157
<script src="/js/trudesk.min.js"></script>
157158
</head>
158159
<body>
@@ -230,10 +231,11 @@
230231
</div>
231232

232233
<script type="text/javascript">
233-
$(document).ready(function() {
234-
setTimeout(function() {
234+
window.truRequire(['jquery'], function(loadedModules) {
235+
var $ = loadedModules[0];
236+
$(window).on('$trudesk:ready', function() {
235237
$('#code').focus();
236-
}, 250);
238+
});
237239
});
238240
</script>
239241
</body>

0 commit comments

Comments
 (0)