twister: do not set case status on flash timeout

Status was set for testcases after a timeout on flash, which does not
abort the process and continues with test execution and eventually
passes the test.

Setting status on the testcases was done too early and before we have
executed the tests.

Also increase the flash timeout to 60s.

Fixes #45845

Signed-off-by: Anas Nashif <[email protected]>

Author: nashif

scripts/pylib/twister/twisterlib.py

@@ -915,7 +915,7 @@ def handle(self):
             stdout = stderr = None
             with subprocess.Popen(command, stderr=subprocess.PIPE, stdout=subprocess.PIPE) as proc:
                 try:
-                    (stdout, stderr) = proc.communicate(timeout=30)
+                    (stdout, stderr) = proc.communicate(timeout=60)
                     # ignore unencodable unicode chars
                     logger.debug(stdout.decode(errors = "ignore"))
 
@@ -926,6 +926,7 @@ def handle(self):
                             dlog_fp.write(stderr.decode())
                         os.write(write_pipe, b'x')  # halt the thread
                 except subprocess.TimeoutExpired:
+                    logger.warning("Flash operation timed out.")
                     proc.kill()
                     (stdout, stderr) = proc.communicate()
                     self.instance.status = "error"
@@ -957,9 +958,6 @@ def handle(self):
 
         handler_time = time.time() - start_time
 
-        if self.instance.status == "error":
-            self.instance.add_missing_testscases("blocked", self.instance.reason)
-
         if harness.is_pytest:
             harness.pytest_run(self.log)
 
@@ -972,6 +970,9 @@ def handle(self):
             self.instance.status = "error"
             self.instance.reason = "No Console Output(Timeout)"
 
+        if self.instance.status == "error":
+            self.instance.add_missing_testscases("blocked", self.instance.reason)
+
         self._final_handle_actions(harness, handler_time)
 
         if post_script: