Fix nullable acts

Author: zerts

src/modules/ethereum/transactions/addressAction/addressActionMain.ts

@@ -24,12 +24,15 @@ export type LocalActionTransaction = Omit<
   hash: string | null;
 };
 
-type LocalAct = Omit<AddressAction['acts'][number], 'transaction'> & {
+type LocalAct = Omit<
+  NonNullable<AddressAction['acts']>[number],
+  'transaction'
+> & {
   transaction: LocalActionTransaction;
 };
 
 export type LocalAddressAction = Omit<AddressAction, 'transaction' | 'acts'> & {
-  acts: LocalAct[];
+  acts: LocalAct[] | null;
   transaction: LocalActionTransaction | null;
   rawTransaction: {
     data?: string | null;
@@ -648,7 +651,7 @@ export function createCancelAddressAction(
 
 export function getActionApprovalFungibleId(action: AnyAddressAction) {
   return (
-    (action?.acts.length === 1 &&
+    (action?.acts?.length === 1 &&
     action.acts[0].content?.approvals?.length === 1 &&
     !action.acts[0].content.transfers
       ? action.acts[0].content.approvals[0].fungible?.id

src/modules/zerion-api/requests/wallet-get-actions.ts

@@ -273,7 +273,7 @@ type Action = {
   };
   /** @description Gasback amount if applicable (when network fee is not free) */
   gasback: null | number;
-  acts: Act[];
+  acts: Act[] | null;
   content: Content | null;
   transaction: ActionTransaction | null;
 };

src/shared/analytics/shared/addressActionToAnalytics.ts

@@ -43,10 +43,10 @@ export function addressActionToAnalytics({
     };
   }
   const outgoing = addressAction.acts
-    .at(0)
+    ?.at(0)
     ?.content?.transfers?.filter(({ direction }) => direction === 'out');
   const incoming = addressAction.acts
-    .at(0)
+    ?.at(0)
     ?.content?.transfers?.filter(({ direction }) => direction === 'in');
 
   const value = {

src/ui/components/address-action/ActInfo/ActInfo.tsx

@@ -154,7 +154,7 @@ export function ActInfo({
   elementEnd,
 }: {
   address: string;
-  act: AnyAddressAction['acts'][number];
+  act: NonNullable<AnyAddressAction['acts']>[number];
   initialDelay: number;
   elementEnd: React.ReactNode;
 }) {

src/ui/components/address-action/AddressActionDetails/AddressActionDetails.tsx

@@ -34,13 +34,13 @@ export function AddressActionDetails({
   const actionWithAppliedAllowance = useMemo(() => {
     if (
       allowanceQuantityCommon == null ||
-      addressAction?.acts.length !== 1 ||
+      addressAction?.acts?.length !== 1 ||
       addressAction.acts[0].content?.approvals?.length !== 1
     ) {
       return addressAction;
     }
     return produce(addressAction, (draft) => {
-      if (draft.acts[0].content?.approvals?.[0].amount) {
+      if (draft.acts?.[0].content?.approvals?.[0].amount) {
         draft.acts[0].content.approvals[0].amount.quantity =
           allowanceQuantityCommon;
         draft.acts[0].content.approvals[0].unlimited = isUnlimitedApproval(
@@ -51,7 +51,7 @@ export function AddressActionDetails({
   }, [addressAction, allowanceQuantityCommon, customAllowanceQuantityBase]);
 
   const showEndElement =
-    addressAction?.acts.length === 1 &&
+    addressAction?.acts?.length === 1 &&
     !addressAction.acts[0].content?.transfers &&
     addressAction.acts[0].content?.approvals?.length === 1;
 

src/ui/components/address-action/TransactionSimulation/TransactionSimulation.tsx

@@ -122,7 +122,7 @@ export function TransactionSimulation({
     interpretAddressAction || localEvmAddressAction || localSolanaAddressAction;
 
   const requestedAllowanceQuantityCommon = addressAction?.acts
-    .at(0)
+    ?.at(0)
     ?.content?.approvals?.at(0)?.amount?.quantity;
 
   const approvalFungibleId = addressAction

src/ui/pages/ActionInfo/ActionInfo.tsx

@@ -196,7 +196,7 @@ function ActContent({
   act,
   showActType,
 }: {
-  act: AddressAction['acts'][number];
+  act: NonNullable<AddressAction['acts']>[number];
   showActType: boolean;
 }) {
   const approvals = act.content?.approvals;
@@ -309,7 +309,7 @@ export function ActionInfo() {
   const actIndex = act_index ? Number(act_index) : undefined;
   const addressAction = state.addressAction as AddressAction | undefined;
   const targetObject =
-    actIndex != null ? addressAction?.acts.at(actIndex) : addressAction;
+    actIndex != null ? addressAction?.acts?.at(actIndex) : addressAction;
 
   const actionDate = useMemo(() => {
     return addressAction?.timestamp
@@ -346,15 +346,15 @@ export function ActionInfo() {
       />
       <VStack gap={16} style={{ marginTop: 16 }}>
         <VStack gap={8}>
-          {actIndex != null && addressAction?.acts[actIndex] ? (
+          {actIndex != null && addressAction?.acts?.at(actIndex) ? (
             <ActContent
               act={addressAction.acts[actIndex]}
               showActType={false}
             />
-          ) : addressAction.acts.length === 1 ? (
+          ) : addressAction.acts?.length === 1 ? (
             <ActContent act={addressAction.acts[0]} showActType={false} />
           ) : (
-            addressAction?.acts.map((act, index) => (
+            addressAction?.acts?.map((act, index) => (
               <div
                 key={index}
                 className={styles.act}

src/ui/pages/History/ActionsList/ActionsList.tsx

@@ -51,7 +51,7 @@ export function ActionsList({
               items={items.map((addressAction) => {
                 const hash =
                   addressAction.transaction?.hash ||
-                  addressAction.acts.at(0)?.transaction.hash ||
+                  addressAction.acts?.at(0)?.transaction.hash ||
                   '';
                 return {
                   key: isLocalAddressAction(addressAction)

src/ui/pages/History/History.tsx

@@ -52,7 +52,9 @@ function mergeLocalAndBackendActions(
   hasMoreBackendActions: boolean
 ) {
   const backendHashes = new Set(
-    backend.map((tx) => tx.transaction?.hash || tx.acts[0].transaction.hash)
+    backend.map(
+      (tx) => tx.transaction?.hash || tx.acts?.at(0)?.transaction.hash
+    )
   );
 
   const lastBackendActionDatetime = backend.at(-1)?.timestamp;
@@ -66,7 +68,7 @@ function mergeLocalAndBackendActions(
       (tx) =>
         tx.transaction?.hash &&
         backendHashes.has(tx.transaction.hash) === false &&
-        !tx.acts.some(
+        !tx.acts?.some(
           (act) =>
             act.transaction.hash && backendHashes.has(act.transaction.hash)
         ) &&

src/ui/pages/SendTransaction/SendTransaction.tsx

@@ -756,9 +756,10 @@ function SendTransactionContent({
   });
 
   const requestedAllowanceQuantityCommon =
-    interpretQuery.data?.action?.acts.at(0)?.content?.approvals?.at(0)?.amount
+    interpretQuery.data?.action?.acts?.at(0)?.content?.approvals?.at(0)?.amount
       ?.quantity ||
-    localAddressAction?.acts.at(0)?.content?.approvals?.at(0)?.amount?.quantity;
+    localAddressAction?.acts?.at(0)?.content?.approvals?.at(0)?.amount
+      ?.quantity;
 
   const requestedAllowanceQuantityBase =
     requestedAllowanceQuantityCommon && fungibleDecimals