Skip to content

Conversation

@zerts
Copy link
Collaborator

@zerts zerts commented Oct 1, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

📦 build.zip

@zerts zerts requested review from Copilot and everdimension and removed request for everdimension October 1, 2025 11:52
@zerts zerts marked this pull request as ready for review October 1, 2025 11:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates portfolio decomposition requests from the legacy defi-sdk to the new ZPI (Zerion API) system. The migration replaces old portfolio data fetching methods with newer API endpoints that provide equivalent functionality.

  • Removes legacy getAddressPortfolio and getAddressesPortfolio functions that used defi-sdk
  • Updates portfolio data access to use new ZPI API structure with camelCase property names
  • Consolidates portfolio querying logic into shared queryWalletPortfolio function

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/ui/shared/requests/PortfolioValue/getAddressPortfolio.ts Completely removed legacy portfolio request function
src/ui/pages/HardwareWalletConnection/shared/getWalletInfo.ts Updated to use new ZPI portfolio API with Promise.all optimization
src/shared/analytics/shared/getUserProperties.ts Migrated portfolio data access to ZPI format and updated property names
src/shared/analytics/shared/getTotalWalletsBalance.ts Removed legacy portfolio balance fetching function
src/modules/zerion-api/hooks/useWalletPortfolio.ts Added shared portfolio query function with consistent configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zerts zerts merged commit 345ef57 into main Oct 22, 2025
2 of 3 checks passed
@zerts zerts deleted the task/extension-move-to-zpi-portfolio-endpoint-WLT-8390 branch October 22, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants