Skip to content

A couple of bugs (or documentation problems) #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkleiman opened this issue Mar 18, 2016 · 1 comment
Open

A couple of bugs (or documentation problems) #10

dkleiman opened this issue Mar 18, 2016 · 1 comment

Comments

@dkleiman
Copy link

Hey there. thanks for writing this package. I just found a couple of problems

In the send function, the data object isn't formatted as specified in the documentation i.e. it has no location field.

Also, perhaps it would be wise to include setting the content headers in the example REST api, since this is necessary. (Otherwise the request body comes up empty).

@zeroasterisk
Copy link
Owner

Both sound like excellent suggestions. I will likely get to them sometime in the not too distant future...

If you felt like submitting a PR, that'd be cool.

Otherwise, I'll get to it when I'm ready to dust off this package again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants