Fix Frient EMI Norwegian HAN divisor (#4396)

Author: TheJulianJES

tests/test_develco.py

@@ -2,9 +2,11 @@
 
 from unittest import mock
 
+import zigpy.types as t
 from zigpy.zcl import ClusterType, foundation
 from zigpy.zcl.clusters.smartenergy import Metering
 
+from tests.common import ClusterListener
 import zhaquirks
 
 zhaquirks.setup()
@@ -137,3 +139,51 @@ async def test_frient_emi(zigpy_device_from_v2_quirk):
         assert attr_data == b"\x00\x00%d\x00\x00\x00\x00\x00"
 
         assert result == (foundation.Status.SUCCESS, "done")
+
+
+async def test_mfg_cluster_events(zigpy_device_from_v2_quirk):
+    """Test Frient EMI Norwegian HAN ignoring incorrect divisor attribute reports."""
+    device = zigpy_device_from_v2_quirk("frient A/S", "EMIZB-132", endpoint_ids=[1, 2])
+
+    metering_cluster = device.endpoints[2].smartenergy_metering
+    metering_listener = ClusterListener(metering_cluster)
+
+    # divisor already fixed at 1000
+    assert metering_cluster.get(Metering.AttributeDefs.divisor.id) == 1000
+
+    # send incorrect divisor attribute report
+    device.packet_received(
+        t.ZigbeePacket(
+            profile_id=260,
+            cluster_id=Metering.cluster_id,
+            src_ep=2,
+            dst_ep=2,
+            # XXX: get data from real device
+            data=t.SerializableBytes(b'\x1c\x00\x00\x01\n\x02\x03"\x00\x02\x00'),
+        )
+    )
+
+    # attribute_updated event should not be emitted
+    assert len(metering_listener.attribute_updates) == 0
+
+    # divisor should still be fixed at 1000
+    assert metering_cluster.get(Metering.AttributeDefs.divisor.id) == 1000
+
+    # send current_summ_delivered attribute report
+    device.packet_received(
+        t.ZigbeePacket(
+            profile_id=260,
+            cluster_id=Metering.cluster_id,
+            src_ep=2,
+            dst_ep=2,
+            data=t.SerializableBytes(
+                b"\x1c\x00\x00\x01\n\x00\x00%\xd2\x04\x00\x00\x00\x00"
+            ),
+        )
+    )
+
+    # attribute_updated event should be emitted
+    assert len(metering_listener.attribute_updates) == 1
+    assert (
+        metering_cluster.get(Metering.AttributeDefs.current_summ_delivered.id) == 1234
+    )

zhaquirks/develco/emi_han.py

@@ -0,0 +1,31 @@
+"""Frient Electricity Meter Interface Norwegian HAN."""
+
+from __future__ import annotations
+
+from typing import Any
+
+from zigpy.quirks import CustomCluster
+from zigpy.quirks.v2 import QuirkBuilder
+import zigpy.types as t
+from zigpy.zcl.clusters.smartenergy import Metering
+
+
+class FrientMetering(CustomCluster, Metering):
+    """Frient EMI Norwegian HAN Metering cluster definition."""
+
+    # fix device issue
+    _CONSTANT_ATTRIBUTES = {Metering.AttributeDefs.divisor.id: 1000}
+
+    def _update_attribute(self, attrid: int | t.uint16_t, value: Any) -> None:
+        """Update attribute with value."""
+        # prevent attribute_updated events for divisor
+        if attrid == Metering.AttributeDefs.divisor.id:
+            return
+        super()._update_attribute(attrid, value)
+
+
+(
+    QuirkBuilder("frient A/S", "EMIZB-132")
+    .replaces(FrientMetering, endpoint_id=2)
+    .add_to_registry()
+)