fix(llm): properly send prompt variable

Author: nicobao

services/api/src/app.ts

@@ -94,6 +94,9 @@ const configSchema = z.object({
     AWS_SECRET_REGION: z.string().optional(),
     AWS_AI_LABEL_SUMMARY_PROMPT_ARN: z.string().optional(),
     AWS_AI_LABEL_SUMMARY_PROMPT_REGION: z.string().default("us-east-1"),
+    AWS_AI_LABEL_SUMMARY_PROMPT_VARIABLE: z
+        .string()
+        .default("conversationInsights"),
     DB_HOST: z.string().optional(),
     DB_PORT: z.coerce.number().int().nonnegative().default(5432),
     DB_NAME: z.string().default("agora"),

services/api/src/commands/polis/import.ts

@@ -408,7 +408,8 @@ async function importToAgora({
             axiosPolis,
             polisDelayToFetch: 0,
             awsAiLabelSummaryPromptArn: undefined, // too expensive to run it at every import..
-            awsAiLabelSummaryPromptRegion: "",
+            awsAiLabelSummaryPromptRegion: "", // unused because of the above
+            awsAiLabelSummaryPromptVariable: "", // unused because of the above
         });
     });
     log.info("Import done");

services/api/src/index.ts

@@ -976,6 +976,8 @@ server.after(() => {
                         actualAwsAiLabelSummaryPromptArn,
                     awsAiLabelSummaryPromptRegion:
                         config.AWS_AI_LABEL_SUMMARY_PROMPT_REGION,
+                    awsAiLabelSummaryPromptVariable:
+                        config.AWS_AI_LABEL_SUMMARY_PROMPT_VARIABLE,
                 });
                 reply.send(castVoteResponse);
                 const proofChannel40EventId =
@@ -1149,11 +1151,6 @@ server.after(() => {
                     didWrite: didWrite,
                     proof: encodedUcan,
                     axiosPolis: axiosPolis,
-                    polisDelayToFetch: config.POLIS_DELAY_TO_FETCH,
-                    awsAiLabelSummaryPromptArn:
-                        actualAwsAiLabelSummaryPromptArn,
-                    awsAiLabelSummaryPromptRegion:
-                        config.AWS_AI_LABEL_SUMMARY_PROMPT_REGION,
                 });
                 reply.send(newOpinionResponse);
                 const proofChannel40EventId =

services/api/src/service/comment.ts

@@ -1018,9 +1018,6 @@ interface PostNewOpinionProps {
     didWrite: string;
     proof: string;
     axiosPolis: AxiosInstance | undefined;
-    polisDelayToFetch: number;
-    awsAiLabelSummaryPromptArn: string | undefined;
-    awsAiLabelSummaryPromptRegion: string;
 }
 
 interface ImportNewOpinionProps {
@@ -1116,9 +1113,6 @@ export async function postNewOpinion({
     didWrite,
     proof,
     axiosPolis,
-    polisDelayToFetch,
-    awsAiLabelSummaryPromptArn,
-    awsAiLabelSummaryPromptRegion,
 }: PostNewOpinionProps): Promise<CreateCommentResponse> {
     const isLocked = await useCommonPost().isPostSlugIdLocked({
         postSlugId: conversationSlugId,
@@ -1252,22 +1246,6 @@ export async function postNewOpinion({
         }
     });
 
-    if (axiosPolis !== undefined) {
-        polisService
-            .delayedPolisGetAndUpdateMath({
-                db,
-                conversationId,
-                conversationSlugId,
-                axiosPolis,
-                polisDelayToFetch,
-                awsAiLabelSummaryPromptArn,
-                awsAiLabelSummaryPromptRegion,
-            })
-            .catch((e: unknown) => {
-                log.error(e);
-            });
-    }
-
     return {
         success: true,
         opinionSlugId: opinionSlugId,

services/api/src/service/llmLabelSummary.ts

@@ -31,6 +31,7 @@ interface UpdateAiLabelsAndSummariesProps {
     conversationId: number;
     awsAiLabelSummaryPromptArn: string | undefined;
     awsAiLabelSummaryPromptRegion: string;
+    awsAiLabelSummaryPromptVariable: string;
 }
 
 interface OpinionInsight {
@@ -59,6 +60,7 @@ export async function updateAiLabelsAndSummaries({
     conversationId,
     awsAiLabelSummaryPromptArn,
     awsAiLabelSummaryPromptRegion,
+    awsAiLabelSummaryPromptVariable,
 }: UpdateAiLabelsAndSummariesProps): Promise<void> {
     if (awsAiLabelSummaryPromptArn === undefined) {
         log.warn(
@@ -74,6 +76,7 @@ export async function updateAiLabelsAndSummaries({
         conversationInsights,
         awsAiLabelSummaryPromptArn,
         awsAiLabelSummaryPromptRegion,
+        awsAiLabelSummaryPromptVariable,
     });
     await doUpdateAiLabelsAndSummaries({
         db,
@@ -177,12 +180,14 @@ interface InvokeRemoteModelProps {
     conversationInsights: ConversationInsights;
     awsAiLabelSummaryPromptArn: string;
     awsAiLabelSummaryPromptRegion: string;
+    awsAiLabelSummaryPromptVariable: string;
 }
 
 async function invokeRemoteModel({
     conversationInsights,
     awsAiLabelSummaryPromptArn,
     awsAiLabelSummaryPromptRegion,
+    awsAiLabelSummaryPromptVariable,
 }: InvokeRemoteModelProps): Promise<
     GenLabelSummaryOutputStrict | GenLabelSummaryOutputLoose
 > {
@@ -193,7 +198,11 @@ async function invokeRemoteModel({
         modelId: awsAiLabelSummaryPromptArn,
         contentType: "application/json",
         accept: "application/json",
-        body: JSON.stringify(conversationInsights),
+        body: JSON.stringify({
+            promptVariables: {
+                [awsAiLabelSummaryPromptVariable]: conversationInsights,
+            },
+        }),
     });
     // we let this throw if any error occurs, it will be caught by the generic error handler
     const response = await client.send(command);

services/api/src/service/polis.ts

@@ -190,6 +190,7 @@ interface DelayedPolisGetAndUpdateMathProps {
     polisDelayToFetch: number;
     awsAiLabelSummaryPromptArn: string | undefined;
     awsAiLabelSummaryPromptRegion: string;
+    awsAiLabelSummaryPromptVariable: string;
 }
 
 export async function delayedPolisGetAndUpdateMath({
@@ -200,6 +201,7 @@ export async function delayedPolisGetAndUpdateMath({
     polisDelayToFetch,
     awsAiLabelSummaryPromptArn,
     awsAiLabelSummaryPromptRegion,
+    awsAiLabelSummaryPromptVariable,
 }: DelayedPolisGetAndUpdateMathProps) {
     if (polisDelayToFetch === -1) {
         log.info("Get polis math results is turned off");
@@ -790,6 +792,7 @@ export async function delayedPolisGetAndUpdateMath({
             conversationId: conversationId,
             awsAiLabelSummaryPromptArn: awsAiLabelSummaryPromptArn,
             awsAiLabelSummaryPromptRegion,
+            awsAiLabelSummaryPromptVariable,
         });
     });
 }

services/api/src/service/voting.ts

@@ -318,6 +318,7 @@ interface CastVoteForOpinionSlugIdProps {
     voteNotifMilestones: number[];
     awsAiLabelSummaryPromptArn: string | undefined;
     awsAiLabelSummaryPromptRegion: string;
+    awsAiLabelSummaryPromptVariable: string;
 }
 
 export async function castVoteForOpinionSlugId({
@@ -332,6 +333,7 @@ export async function castVoteForOpinionSlugId({
     voteNotifMilestones,
     awsAiLabelSummaryPromptArn,
     awsAiLabelSummaryPromptRegion,
+    awsAiLabelSummaryPromptVariable,
 }: CastVoteForOpinionSlugIdProps): Promise<boolean> {
     const { conversationSlugId, conversationId } =
         await useCommonComment().getOpinionMetadataFromOpinionSlugId({
@@ -695,6 +697,7 @@ export async function castVoteForOpinionSlugId({
                 polisDelayToFetch,
                 awsAiLabelSummaryPromptArn,
                 awsAiLabelSummaryPromptRegion,
+                awsAiLabelSummaryPromptVariable, // unused because of the above
             })
             .catch((e: unknown) => {
                 log.error(e);