fix: /api/v1/user/conversation/fetch endpoint zod return body schema is too strict or something is wrong in its implementation

[nicobao]

Backend logs:

[21:53:18 UTC] ERROR: Internal Server Error
    reqId: "req-2c"
    req: {
      "method": "POST",
      "url": "/api/v1/user/conversation/fetch",
      "host": "localhost:8080",
      "remoteAddress": "127.0.0.1",
      "remotePort": 32960
    }
    res: {
      "statusCode": 500
    }
    err: {
      "type": "InternalServerError",
      "message": "Internal Server Error: Response doesn't match the schema: [\n  {\n    \"code\": \"too_small\",\n    \"minimum\": 0,\n    \"type\": \"number\",\n    \"inclusive\": true,\n    \"exact\": false,\n    \"message\": \"Number must be greater than or equal to 0\",\n    \"path\": [\n      1,\n      \"metadata\",\n      \"opinionCount\"\n    ]\n  }\n]",
      "stack":
          InternalServerError: Internal Server Error
              at Object.internalServerError (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/@[email protected]/node_modules/@fastify/sensible/lib/httpErrors.js:137:12)
              at Object.<anonymous> (/home/nicobao/zkorum/agora/services/api/src/index.ts:192:48)
              at handleError (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/error-handler.js:69:20)
              at onErrorHook (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/reply.js:803:5)
              at preSerializationHookEnd (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/reply.js:508:5)
              at preSerializationHook (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/reply.js:488:5)
              at _Reply.Reply.send (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/reply.js:203:7)
              at <anonymous> (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/wrapThenable.js:34:17)
              at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
          caused by: FastifyError: Response doesn't match the schema
              at ResponseSerializationError (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/fastify-type-provider-zod/dist/src/errors.js:11:9)
              at <anonymous> (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/fastify-type-provider-zod/dist/src/core.js:89:15)
              at serialize (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/reply.js:921:12)
              at preSerializationHookEnd (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/reply.js:504:17)
              at preSerializationHook (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/reply.js:488:5)
              at _Reply.Reply.send (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/reply.js:203:7)
              at <anonymous> (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/wrapThenable.js:34:17)
              at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
          caused by: ZodError: [
            {
              "code": "too_small",
              "minimum": 0,
              "type": "number",
              "inclusive": true,
              "exact": false,
              "message": "Number must be greater than or equal to 0",
              "path": [
                1,
                "metadata",
                "opinionCount"
              ]
            }
          ]
              at get error [as error] (file:///home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/zod/lib/index.mjs:587:31)
              at <anonymous> (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/fastify-type-provider-zod/dist/src/core.js:88:16)
              at serialize (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/reply.js:921:12)
              at preSerializationHookEnd (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/reply.js:504:17)
              at preSerializationHook (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/reply.js:488:5)
              at _Reply.Reply.send (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/reply.js:203:7)
              at <anonymous> (/home/nicobao/zkorum/agora/services/api/node_modules/.pnpm/[email protected]/node_modules/fastify/lib/wrapThenable.js:34:17)
              at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      "status": 500,
      "statusCode": 500,
      "expose": false
    }
[21:53:18 UTC] INFO: request completed
    reqId: "req-2c"
    res: {
      "statusCode": 500
    }
    responseTime: 68.30636200122535

[e32wong]

This is happening because the opinion count went negative. Can you provide a reproduction or describe what lead up to this error?

The opinion count should only decrement when an opinion is deleted successfully, and we currently have a db transaction to make sure it doesn't decrement unless it is successful.

[e32wong]

If you don't have a reproduction, please dump the following command from SQL:

select * from "conversation" order by "created_at" desc;