all_channels: Also confirm before unsubscribing here, not just action sheet

Fixes #1878.

Author: chrisbobbe

lib/widgets/all_channels.dart

@@ -6,6 +6,7 @@ import '../generated/l10n/zulip_localizations.dart';
 import '../log.dart';
 import '../model/channel.dart';
 import 'action_sheet.dart';
+import 'actions.dart';
 import 'app_bar.dart';
 import 'button.dart';
 import 'icons.dart';
@@ -137,8 +138,8 @@ class _SubscribeToggle extends StatelessWidget {
           await subscribeToChannel(store.connection,
             subscriptions: [channel.name]);
         } else {
-          await unsubscribeFromChannel(store.connection,
-            subscriptions: [channel.name]);
+          await ZulipAction.unsubscribeFromChannel(context,
+            channelId: channel.streamId);
         }
       },
       // TODO(#741) interpret API errors for user

test/widgets/all_channels_test.dart

@@ -13,6 +13,7 @@ import 'package:zulip/widgets/button.dart';
 import 'package:zulip/widgets/home.dart';
 import 'package:zulip/widgets/icons.dart';
 import 'package:zulip/widgets/page.dart';
+import 'package:zulip/widgets/remote_settings.dart';
 import 'package:zulip/widgets/theme.dart';
 
 import '../api/fake_api.dart';
@@ -23,6 +24,7 @@ import '../example_data.dart' as eg;
 import '../model/test_store.dart';
 import '../stdlib_checks.dart';
 import 'checks.dart';
+import 'dialog_checks.dart';
 import 'test_app.dart';
 
 void main() {
@@ -238,4 +240,37 @@ void main() {
         'subscriptions': jsonEncode([channel.name]),
       });
   });
+
+  testWidgets('Toggle "off" to unsubscribe, but without resubscribe permission', (tester) async {
+    final channel = eg.stream(
+      inviteOnly: true, canSubscribeGroup: eg.groupSetting(members: []));
+    final subscription = eg.subscription(channel);
+
+    (Widget, Widget) checkConfirmDialog() => checkSuggestedActionDialog(tester,
+      expectedTitle: 'Unsubscribe from ${channel.name}?',
+      expectedMessage: 'Once you leave this channel, you will not be able to rejoin.',
+      expectDestructiveActionButton: true,
+      expectedActionButtonText: 'Unsubscribe');
+
+    await setupAllChannelsPage(tester, channels: [subscription]);
+
+    await tester.tap(find.byType(Toggle));
+    await tester.pump();
+    final (_, cancelButton) = checkConfirmDialog();
+    await tester.tap(find.byWidget(cancelButton));
+    await tester.pump();
+    check(connection.lastRequest).isNull();
+    await tester.pump(RemoteSettingBuilder.localEchoIdleTimeout);
+
+    await tester.tap(find.byType(Toggle));
+    await tester.pump();
+    final (unsubscribeButton, _) = checkConfirmDialog();
+    await tester.tap(find.byWidget(unsubscribeButton));
+    check(connection.lastRequest).isA<http.Request>()
+      ..method.equals('DELETE')
+      ..url.path.equals('/api/v1/users/me/subscriptions')
+      ..bodyFields.deepEquals({
+        'subscriptions': jsonEncode([channel.name]),
+      });
+  });
 }