user [nfc]: Rename New1to1PmScreen from UsersScreen

There are lots of screens in the app that show users, or even
all users.  This screen in reality has a very specific role.
Name it accordingly.

Also move it next to the parallel NewGroupPmScreen component.

Author: gnprice

src/nav/AppNavigator.js

@@ -29,7 +29,7 @@ import MessageReactionsScreen from '../reactions/MessageReactionsScreen';
 import AccountDetailsScreen from '../account-info/AccountDetailsScreen';
 import PmConversationDetailsScreen from '../chat/PmConversationDetailsScreen';
 import SearchMessagesScreen from '../search/SearchMessagesScreen';
-import UsersScreen from '../users/UsersScreen';
+import New1to1PmScreen from '../user-picker/New1to1PmScreen';
 import ChatScreen from '../chat/ChatScreen';
 import LanguageScreen from '../settings/LanguageScreen';
 import PasswordAuthScreen from '../start/PasswordAuthScreen';
@@ -70,7 +70,7 @@ export type AppNavigatorParamList = {|
   +'password-auth': RouteParamsOf<typeof PasswordAuthScreen>,
   +'realm-input': RouteParamsOf<typeof RealmInputScreen>,
   +'search-messages': RouteParamsOf<typeof SearchMessagesScreen>,
-  +users: RouteParamsOf<typeof UsersScreen>,
+  +'new-1to1-pm': RouteParamsOf<typeof New1to1PmScreen>,
   +language: RouteParamsOf<typeof LanguageScreen>,
   +lightbox: RouteParamsOf<typeof LightboxScreen>,
   +'new-group-pm': RouteParamsOf<typeof NewGroupPmScreen>,
@@ -178,7 +178,7 @@ export default function AppNavigator(props: Props): Node {
         name="search-messages"
         component={useHaveServerDataGate(SearchMessagesScreen)}
       />
-      <Stack.Screen name="users" component={useHaveServerDataGate(UsersScreen)} />
+      <Stack.Screen name="new-1to1-pm" component={useHaveServerDataGate(New1to1PmScreen)} />
       <Stack.Screen name="language" component={useHaveServerDataGate(LanguageScreen)} />
       <Stack.Screen name="lightbox" component={useHaveServerDataGate(LightboxScreen)} />
       <Stack.Screen name="new-group-pm" component={useHaveServerDataGate(NewGroupPmScreen)} />

src/pm-conversations/PmConversationsScreen.js

@@ -63,7 +63,7 @@ export default function PmConversationsScreen(props: Props): Node {
           style={styles.button}
           text="New PM"
           onPress={() => {
-            setTimeout(() => navigation.push('users'));
+            setTimeout(() => navigation.push('new-1to1-pm'));
           }}
         />
         <ZulipButton

src/users/UsersScreen.js renamed to src/user-picker/New1to1PmScreen.js

@@ -5,7 +5,7 @@ import type { Node } from 'react';
 import type { RouteProp } from '../react-navigation';
 import type { AppNavigationProp } from '../nav/AppNavigator';
 import Screen from '../common/Screen';
-import UserList from './UserList';
+import UserList from '../users/UserList';
 import type { UserOrBot } from '../types';
 import { useSelector, useDispatch } from '../react-redux';
 import { pm1to1NarrowFromUser } from '../utils/narrow';
@@ -14,11 +14,11 @@ import { navigateBack, doNarrow } from '../actions';
 import { useNavigation } from '../react-navigation';
 
 type Props = $ReadOnly<{|
-  navigation: AppNavigationProp<'users'>,
-  route: RouteProp<'users', void>,
+  navigation: AppNavigationProp<'new-1to1-pm'>,
+  route: RouteProp<'new-1to1-pm', void>,
 |}>;
 
-export default function UsersScreen(props: Props): Node {
+export default function New1to1PmScreen(props: Props): Node {
   const dispatch = useDispatch();
   const users = useSelector(getUsers);
   const presences = useSelector(getPresence);