Change to linear filtering #858
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Already implemented in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in essence a continuation of #819, setting the texture filters to linear for a smoother look at resolutions above 1080p, while removing artifacting and still allowing textures such as scrolling backgrounds to repeat.
I tried to keep it compatible with existing skins the best I could, so I ended up making clamp to edge the default for most textures, requiring only repeating textures to be manually set to repeat. The helper function
CTexture.tSetWrapModecan be used to change the wrap mode, and there is an additional Lua functionSetWrapModefor use in skin scripts. Instead of setting it directly, the wrap mode can also be passed toAddGraphwhich makes updating skins very easy (see changes).NB I have not changed all scripts in the Open-World Memories skin yet, only those that appear in standard play, but I'll edit those as well if the changes are approved.