[Feat] Refactor repo with build tools #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
Closes #5
Following the conversation regarding the maintainability of this codebase, here are changes that address them all:
There are many changes so I would advice you to carefully review at least the main logic files in
libs/core
.I would also strongly suggest adding a CI (Continuous Integration) to be able to constantly build extensions here in Github Actions and maybe even add an auto-release workflow to publish extensions automatically to respective stores.
And maybe adding some unit tests at least for the core logic would be great too.
For the future improvements I would also suggest dropping jQuery from UI and replacing it with something more modern like Bootstrap or similar.
Also it is probably a good idea to move out all the classes for adblocking into a config which could be fetched remotely so the extension does not have to be updated to pickup new config.
Please have a look and let me know what do you think.
Cheers!