-
Notifications
You must be signed in to change notification settings - Fork 2
Added default path flow #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1,362
−776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4cf47f2 to
ebdecda
Compare
Contributor
Author
|
Related example PR : 0xAtelerix/example#14 There are also changed in pelacli regarding default multichain and ext-network config for which I will raise PR once the SDK PR is finalized and merged. |
0xaigen
reviewed
Dec 17, 2025
Appchain now reads from {dataDir}/consensus/txbatch/{chainID}
to match where pelacli fetcher writes the data.
JekaMas
requested changes
Dec 30, 2025
JekaMas
reviewed
Dec 30, 2025
JekaMas
reviewed
Dec 30, 2025
JekaMas
reviewed
Dec 30, 2025
JekaMas
reviewed
Dec 30, 2025
JekaMas
reviewed
Dec 30, 2025
JekaMas
reviewed
Dec 30, 2025
JekaMas
reviewed
Dec 30, 2025
JekaMas
reviewed
Dec 30, 2025
JekaMas
reviewed
Dec 30, 2025
JekaMas
reviewed
Dec 30, 2025
JekaMas
reviewed
Dec 30, 2025
JekaMas
reviewed
Dec 30, 2025
JekaMas
reviewed
Dec 30, 2025
JekaMas
reviewed
Dec 30, 2025
Merged
JekaMas
approved these changes
Dec 30, 2025
0xaigen
reviewed
Dec 30, 2025
0xaigen
reviewed
Dec 30, 2025
0xaigen
reviewed
Dec 30, 2025
Code Metrics Report
Details | | #32 (bfb63d8) | #32 (12600cf) | +/- |
|---------------------|---------------|---------------|------|
| Coverage | 58.7% | 58.7% | 0.0% |
| Files | 56 | 56 | 0 |
| Lines | 2902 | 2902 | 0 |
| Covered | 1706 | 1706 | 0 |
- | Code to Test Ratio | 1:0.4 | 1:0.4 | -0.1 |
| Code | 13642 | 13651 | +9 |
| Test | 6359 | 6359 | 0 |
| Test Execution Time | 1m6s | 1m6s | 0s |Code coverage of files in pull request scope (40.7% → 40.7%)
Reported by octocov |
0xaigen
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
Introduces Storage[AppTx, R] struct that consolidates all databases (appchain, txpool, txbatch) and components (multichain, subscriber) with unified lifecycle management and accessor methods.
Defines three-layer data directory structure (multichain/{chainID}/, consensus/txbatch/{chainID}/, appchain/db/) with helper functions for consistent path resolution across SDK and pelacli.
InitApp() orchestrates full appchain bootstrap—waits for required chains, opens all databases, creates multichain accessor and subscriber—reducing ~60 lines of boilerplate to one function call.