refactor(cli): improve code quality with nullish coalescing operators#229
Open
refactor(cli): improve code quality with nullish coalescing operators#229
Conversation
- Replace logical OR (||) with nullish coalescing (??) for safer error handling - Updated error message fallbacks in build, dream, run, and resume commands - Updated buildPath fallbacks to use nullish coalescing - Reduces eslint warnings and follows modern TypeScript best practices This change makes the code more resilient by only falling back to default values when the property is null or undefined, not when it's an empty string or other falsy values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Improves code quality by replacing logical OR operators with nullish coalescing operators in CLI commands.
Changes:
result.error || 'Unknown error'withresult.error ?? 'Unknown error'result.error || 'Unknown error'withresult.error ?? 'Unknown error'result.error || 'Unknown error'withresult.error ?? 'Unknown error'result.error || 'Unknown error'withresult.error ?? 'Unknown error'result.buildPath || 'N/A'withresult.buildPath ?? 'N/A'Why:
Testing:
This is part of a larger code quality improvement initiative. The nullish coalescing operator (??) is safer than logical OR (||) because it only provides fallbacks for null/undefined values, not for other falsy values like empty strings or zero.