Snapshot Approximation public array state#77
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
0xC000005
force-pushed
the
audit/cycle-12-approx-public-state
branch
2 times, most recently
from
11c2f1f to
085cea5
Compare
0xC000005
force-pushed
the
audit/cycle-12-approx-public-state
branch
from
085cea5 to
b341d1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChebyshevApproximationpublic array properties:Domain,NNodes,NodeArrays,TensorValues,Weights, andDiffMatrices.ChebyshevApproximationinternals to private backing fields so evaluation/build/algebra paths do not read clone-returning public properties.AdaptiveBuild,Algebra, spline JSON load) that need direct owned state.Refs #73.
Why This Is A Staged Slice
Issue #73 is broader than Approximation. This PR hardens only
ChebyshevApproximationbecause it requires a backing-field refactor rather than a one-line clone-on-get patch. Spline, Slider, wrapper records, SobolResult, and cached evaluation buffers remain follow-up work.Verification
ApproxPublicStateOwnershipTestsinitially failed 3/3 because returned arrays were live and mutations corrupted behavior.dotnet test tests/ChebyshevSharp.Tests/ChebyshevSharp.Tests.csproj --configuration Release --no-restore --filter FullyQualifiedName~ApproxPublicStateOwnershipTests --verbosity minimal-> 3/3 passed.Approx|FromValues|Algebra|Serialization|SobolIndices|ExtrudeSlice) -> 397/397 passed.dotnet test --configuration Release --no-restore --verbosity minimal-> 1512/1512 passed.dotnet restore,dotnet build --configuration Release --no-restore --verbosity minimalpassed with 0 warnings/errors.dotnet format --verify-no-changes --verbosity minimal-> passed.dotnet pack src/ChebyshevSharp --configuration Release --no-build --output /tmp/chebsharp-cycle12-approx-pack-> createdChebyshevSharp.0.12.0.nupkg.git diff --check-> passed.