ci: Use shared workspace release workflow#938
Merged
Conversation
huitseeker
added
the
no changelog
huitseeker
force-pushed
the
ci/use-reusable-workspace-release
branch
9 times, most recently
from
64dbeda to
4bc66a0
Compare
huitseeker
force-pushed
the
ci/use-reusable-workspace-release
branch
from
4bc66a0 to
526594e
Compare
huitseeker
changed the title
bobbinth
approved these changes
Apr 30, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you!
Note for @bobbinth : This operation might (but should not, from what I could gather) require changing the trusted publishing workflow configured for the
p3-midenand crypto crates (that should be set to the caller workflow right now, and might need setting to the callee).
I guess the path forward here is to just try to do the release, and if it doesn't work, update the settings - right?
Collaborator
Author
Correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches the dry-run and publish workflows to the shared release workflow in
0xMiden/.github: 0xMiden/.github#11It passes
scripts/check-msrv.shexplicitly and removes the old local release action.Removed unnecessary OIDC permissions from the workspace release dry-run caller while keeping publish permissions unchanged.
Note for @bobbinth : This operation might (but should not, from what I could gather) require changing the trusted publishing workflow configured for the
p3-midenand crypto crates (that should be set to the caller workflow right now, and might need setting to the callee).