Harden LargeSmt reader snapshots#980
Merged
sergerad merged 1 commit intosergerad-largesmt-reader-traitfrom Apr 21, 2026
Merged
Conversation
huitseeker
added
the
no changelog
sergerad
merged commit 77bc5c4
into
sergerad-largesmt-reader-trait
25 of 26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LargeSmt::reader()is now fallible, so storage errors propagate instead of panicking.RocksDbStorage::reader()now builds a detached memory-backedSmtStorageReadersnapshot and returnsStorageErroron iterator/materialization failure.RocksDbStoragekeeps its publicCloneimpl.LargeSmtcloning is gated behind a newCloneableSmtStorageReadermarker, so cloneability is explicit for safe detached storage types.RocksDBregression test proving the reader is a detached snapshot after subsequent writes.Addresses #967 (comment)
and #967 (comment) and associated comments