feat(mempool): Avoid allocating in SelectedBatch query#1991
Open
Mirko-von-Leipzig wants to merge 3 commits intomainfrom
Open
feat(mempool): Avoid allocating in SelectedBatch query#1991Mirko-von-Leipzig wants to merge 3 commits intomainfrom
SelectedBatch query#1991Mirko-von-Leipzig wants to merge 3 commits intomainfrom
Conversation
Mirko-von-Leipzig
added
the
no changelog
Mirko-von-Leipzig
force-pushed
the
mirko/mempool-perf
branch
from
37eea17 to
031f8a5
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/mempool-perf
branch
from
031f8a5 to
3a9fc1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current impl allocated every time a batch is queried for its unauthenticated notes.
Instead we now construct this list when the batch is created, avoiding the repeated allocation.
This won't have a perceivable effect at our current scale, but still a good thing to handle.
Closes #1878