Skip to content

feat(rpc): cache reference block commitments#1996

Merged
Mirko-von-Leipzig merged 3 commits intomainfrom
mirko/cache-reference-blocks
Apr 24, 2026
Merged

feat(rpc): cache reference block commitments#1996
Mirko-von-Leipzig merged 3 commits intomainfrom
mirko/cache-reference-blocks

Conversation

@Mirko-von-Leipzig
Copy link
Copy Markdown
Collaborator

Adds an LRU cache to avoid going to the store to verify the reference block of submitted transactions and batches.

The check was also completely missing for SubmitProvenTransaction afaict.

We're fairly sparse on tests here - for example no batch tests. We should figure out a better approach.

Closes #1992

@Mirko-von-Leipzig Mirko-von-Leipzig added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Apr 23, 2026
@Mirko-von-Leipzig Mirko-von-Leipzig changed the title feat(rpc): cache reference block commitements feat(rpc): cache reference block commitments Apr 23, 2026
@Mirko-von-Leipzig Mirko-von-Leipzig force-pushed the mirko/cache-reference-blocks branch from 247e0ed to bcefc13 Compare April 23, 2026 13:27
Copy link
Copy Markdown
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

Comment thread crates/rpc/src/server/api.rs Outdated
@Mirko-von-Leipzig Mirko-von-Leipzig force-pushed the mirko/cache-reference-blocks branch from 0b1f786 to 6a2d442 Compare April 24, 2026 07:39
@Mirko-von-Leipzig Mirko-von-Leipzig merged commit 8a73b9f into main Apr 24, 2026
18 checks passed
@Mirko-von-Leipzig Mirko-von-Leipzig deleted the mirko/cache-reference-blocks branch April 24, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants