chore: add Service trait in monitor#2003
Draft
SantiagoPittella wants to merge 1 commit intosantiagopittella-dynamic-server-statefrom
Draft
chore: add Service trait in monitor#2003SantiagoPittella wants to merge 1 commit intosantiagopittella-dynamic-server-statefrom
Service trait in monitor#2003SantiagoPittella wants to merge 1 commit intosantiagopittella-dynamic-server-statefrom
Conversation
SantiagoPittella
added
the
no changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the network monitor's checker tasks around a common
Servicetrait and splits the remote prover monitor into two cooperating tasks.ServicetraitEvery checker now implements a single
Servicetrait withname / interval / initial_status / checkand a defaultrunloop.Tasks::spawn_serviceseeds thewatch::channelfrominitial_status()and drives the service.