Improve SQL store indices and queries - #2364
Open
gabrielbosio wants to merge 25 commits into
Open
Conversation
gabrielbosio
force-pushed
the
sql_store_indices_and_queries
branch
from
August 10, 2026 15:51
6319c1f to
ecb7b03
Compare
juan518munoz
marked this pull request as ready for review
August 18, 2026 15:30
SantiagoPittella
approved these changes
Aug 19, 2026
SantiagoPittella
left a comment
Collaborator
There was a problem hiding this comment.
we could use a CLI test for the new command too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_unspent_input_note_nullifiersso that it doesn't take into account invalid notes as unspent notes.INSERT OR REPLACEqueries toINSERT INTO ... ON CONFLICT UPDATEhas_client_notes=true/falsetohas_client_notes=1/0. For thetruecase, it enforces index usage besides keeping consistency.consumer_account_idas the first column of theidx_input_notes_consumption.get_input_note_by_offsetgrow quadratic instead of superlinear so the PR also replacesget_input_note_by_offsetwithget_input_note_afterto avoid usingOFFSETs in the SQL store query and instead pass the WHERE values that define the note order the user wants as argument.make bench-storeto benchmark account/inputs scaling.note-idtie-break onNoteFilter::Consumedquery.InputNoteReadertest coverageThis PR along one that adds query-plan regression tests would close #2348.