fix: reject zero-valued RPC limits to prevent chunks(0) panic - #2398
Merged
Conversation
Collaborator
|
@dumanoglu1 can you fix the CI checks? |
Contributor
Author
|
Pushed 2915b2a to fix the CI compile/format issues from the regression test. The new pull_request workflow runs are currently marked �ction_required, so they need maintainer approval before GitHub Actions will execute them. |
midasbal
pushed a commit
to midasbal/rust-sdk
that referenced
this pull request
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Reject zero-valued RPC limits while converting the node
GetLimitsresponse intoRpcLimits, and add a regression test for a zeronote_idlimit.Why
The client uses these limits as chunk sizes for note IDs, tags, nullifier prefixes, and account IDs. Rust's
slice::chunks(0)panics, so a malformed node response could crash the client instead of returning an RPC conversion error.Fixes #2394
Validation
git diff --check -- crates/rust-client/src/rpc/domain/limits.rscargo test -p miden-client rejects_zero_limits_from_rpc_response -- --nocapturecould not complete locally becausemiden-node-proto-buildfailed before reaching this test:remote_prover.proto is not in any include path.cargo check -p miden-client --no-default-featureshit the same dependency build-script failure.