fix(rpc): validate a stored transaction encryption key on decode - #2411
Open
Xowiek wants to merge 1 commit into
Open
fix(rpc): validate a stored transaction encryption key on decode#2411Xowiek wants to merge 1 commit into
Xowiek wants to merge 1 commit into
Conversation
TransactionEncryptionKey documents verify() as its only constructor, so a key reaching the seal path has been vouched for by a chain-recognized validator. Deserializable is a second constructor and skipped both checks verify() makes: the IES scheme and the key id bounds. The key is cached in the store after verification and read back through Deserializable, and the cached value is not re-verified, so a corrupt row decoded into a key the seal path treated as verified. The attestation cannot be rechecked on decode, since it is not serialized and the trust anchors are not available there, but the invariants that do not depend on it are now enforced. The key id length is bounded before the read so a corrupt length cannot ask for a large allocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TransactionEncryptionKey documents verify as its only constructor, so a key that
reaches the seal path has been vouched for by a chain-recognized validator.
Deserializable is a second constructor and it skipped both checks verify makes,
the IES scheme and the key id bounds.
The key is cached in the store after verification and read back through
Deserializable, and the cached value is never re-verified, so a corrupt row
decoded into a key the seal path treated as verified.
The attestation itself cannot be rechecked on decode, since it is not serialized
and the trust anchors are not there, but the invariants that do not depend on it
are now enforced. The key id length is bounded before the read so a corrupt
length cannot ask for a large allocation.
Three tests: a verified key still round-trips, an unsupported scheme is
rejected, and an empty or oversized key id is rejected. The last two fail on next.