fix(cli): report the actual outcome of tags --add and --remove - #2416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tags --addandtags --removeprint that the tag was added or removed no matter what happened. The store already reports whether a row was written or deleted, butClient::add_note_tagandClient::remove_note_tagdrop that and onlywarn!about it, so the command ends up contradicting its own log line:Both methods now return that flag instead of logging it, and the CLI prints accordingly:
The return type change doesn't touch any existing caller, since
?andunwrap()discard thebool, so onlytags.rsneeded updating. Extended the existingtagstest to assert the returned value, and fixed theStore::remove_note_tagdoc comment, which described aboolreturn the method doesn't have.