Skip to content

Conversation

@ed255
Copy link
Collaborator

@ed255 ed255 commented Oct 20, 2025

Resolve #433

When creating a statement from an operation we take a vector that will define some initial values of the wildcard map.

@artwyman
Copy link
Collaborator

This looks good to me. I tried it out on a private branch with my crafting predicates and it seems to work.
I'll defer to someone who knows this code better to be official reviewer.

@ed255 ed255 requested a review from dgulotta October 21, 2025 08:30
Copy link
Collaborator

@dgulotta dgulotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest raising an error if the user tries to assign the same wildcard twice, but otherwise it looks good to me.

@ed255
Copy link
Collaborator Author

ed255 commented Oct 27, 2025

I'd suggest raising an error if the user tries to assign the same wildcard twice, but otherwise it looks good to me.

Thanks for the suggestion! I've implemented it in 7c4e354

@ed255 ed255 merged commit c382bf4 into main Oct 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't build custom statements with unconstrained wildcards

4 participants