Skip to content

Including Missing Metrics from Import Blocks path into Production#2139

Open
lucca30 wants to merge 3 commits intodevelopfrom
lmartins/missing-metrics-for-bp
Open

Including Missing Metrics from Import Blocks path into Production#2139
lucca30 wants to merge 3 commits intodevelopfrom
lmartins/missing-metrics-for-bp

Conversation

@lucca30
Copy link
Contributor

@lucca30 lucca30 commented Mar 12, 2026

Description

By default Geth has a good sort of metrics included on the flow of importing blocks while keep a gap on the same metrics for the worker. This task aims to mirror the missing metrics which were worth, to bring more visibility for future cases.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@lucca30 lucca30 requested a review from a team March 12, 2026 01:13
@claude
Copy link

claude bot commented Mar 12, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 88.52459% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.52%. Comparing base (5eb6b6c) to head (394094e).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
miner/worker.go 88.23% 4 Missing and 2 partials ⚠️
consensus/bor/bor.go 50.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (88.52%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2139      +/-   ##
===========================================
+ Coverage    51.50%   51.52%   +0.02%     
===========================================
  Files          882      882              
  Lines       154081   154139      +58     
===========================================
+ Hits         79352    79415      +63     
+ Misses       69552    69543       -9     
- Partials      5177     5181       +4     
Files with missing lines Coverage Δ
core/state/statedb.go 67.11% <100.00%> (+0.21%) ⬆️
consensus/bor/bor.go 83.93% <50.00%> (-0.06%) ⬇️
miner/worker.go 70.73% <88.23%> (+2.16%) ⬆️

... and 20 files with indirect coverage changes

Files with missing lines Coverage Δ
core/state/statedb.go 67.11% <100.00%> (+0.21%) ⬆️
consensus/bor/bor.go 83.93% <50.00%> (-0.06%) ⬇️
miner/worker.go 70.73% <88.23%> (+2.16%) ⬆️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant