Write stack multiset check constraints in AirScript #272
+1,260
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fumuran
force-pushed
the
andrew-stack-multiset-constraints
branch
from
e48e04b to
fdc45a1
Compare
bobbinth
reviewed
May 2, 2023
constraints/miden-vm/stack.air
Outdated
Comment on lines
241
to
250
| ev u32and_bus_constraint([stack_top[16]], [b_chip]): | ||
| # and_req_val represents bitwise operation request value. | ||
| let and_req_val = $alpha[0] + | ||
| $alpha[1] * BITWISE_AND + | ||
| $alpha[2] * stack_top[0] + | ||
| $alpha[3] * stack_top[1] + | ||
| $alpha[4] * stack_top[0]' | ||
|
|
||
| # Enforce u32and bus constraint. | ||
| enf b_chip' * and_req_val = b_chip |
There was a problem hiding this comment.
I don't think we can write bus constraints this way. This captures only one half of the constraint (the request part) but we need to capture both parts (request and response) in the same constraint.
What we should probably do is to create a separate file for each bus and describe bus constraints there fully.
Fumuran
force-pushed
the
andrew-stack-general-constraints
branch
from
0f3097d to
445393e
Compare
Fumuran
force-pushed
the
andrew-stack-general-constraints
branch
3 times, most recently
from
f2a39c2 to
146c947
Compare
Fumuran
force-pushed
the
andrew-stack-multiset-constraints
branch
from
fdc45a1 to
793e0a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addressing: #203
This PR adds multiset check constraints for stack operations and removes keywords from evaluator function declaration.