-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: implement buses #371
Open
Leo-Besancon
wants to merge
42
commits into
0xPolygonMiden:next
Choose a base branch
from
massalabs:feat-implement-bus
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+4,090
−367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still needs additional checks (e.g. ensure Null only on buses boundaries, and ensure buses boundaries only on Null)
- fixed stack overflow on hash and eq with Singleton - mir comparision utils - buses test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR implementing #183, targetting upstream next (instead of massalabs#8 on massalabs's fork).
The goal of this PR is to make an initial implementation of buses, that can be declared:
Currently, only empty bus boundary constraints are handled (that are reduced to a
0
or1
value depending on the bus type)Boundary constraints with public inputs depend on #143 and will be handled in a future PR.
What was done in this PR:
In future PR, we will introduce, in order of priority: