Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add SMT benchmarks #384

Merged
merged 1 commit into from
Feb 25, 2025
Merged

docs: add SMT benchmarks #384

merged 1 commit into from
Feb 25, 2025

Conversation

Qyriad
Copy link
Contributor

@Qyriad Qyriad commented Feb 19, 2025

Describe your changes

Closes #373.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

bobbinth
bobbinth reviewed Feb 19, 2025
View reviewed changes
bobbinth
bobbinth reviewed Feb 19, 2025
View reviewed changes
@Qyriad Qyriad force-pushed the qyriad/docs/smt-benchmarks branch from cc92a12 to be10728 Compare February 24, 2025 16:40
@Qyriad Qyriad requested a review from bobbinth February 24, 2025 16:40
bobbinth
bobbinth approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left one small comment inline - but other than that, this is good to go.

@Qyriad Qyriad force-pushed the qyriad/docs/smt-benchmarks branch from be10728 to fcb01b7 Compare February 25, 2025 15:36
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Qyriad
Copy link
Contributor Author

Qyriad commented Feb 25, 2025

Fixed!

@bobbinth bobbinth added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Feb 25, 2025
@bobbinth bobbinth merged commit 1e87cd6 into 0xPolygonMiden:next Feb 25, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
no changelog This PR does not require an entry in the `CHANGELOG.md` file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qyriad @bobbinth