Skip to content

[codex] TASK(WORKSPACE-A157014E8DCFDAFA)-3: fix(web): prevent Enter from sending while Chinese IME composition is active in chat composer#249

Draft
zhangweijian97 wants to merge 1 commit into
mainfrom
workspace-a157014e8dcfdafa/3
Draft

[codex] TASK(WORKSPACE-A157014E8DCFDAFA)-3: fix(web): prevent Enter from sending while Chinese IME composition is active in chat composer#249
zhangweijian97 wants to merge 1 commit into
mainfrom
workspace-a157014e8dcfdafa/3

Conversation

@zhangweijian97

Copy link
Copy Markdown
Collaborator

Linear issue: TASK(WORKSPACE-A157014E8DCFDAFA)-3

This PR was created by the devos.ing ADHD (Agentic Development Hub & Daemon) workflow.

Includes:

  • plan + implement session output
  • separate review/testing session

…rom sending while Chinese IME composition is active in chat composer
@zhangweijian97

Copy link
Copy Markdown
Collaborator Author

Review Status: FAIL

Scoped review of packages/web/src/components/chat-room/chat-composer.tsx is correct for the requested behavior: Enter && event.nativeEvent.isComposing now exits before command selection/submit logic, and non-IME Enter handling remains unchanged.

Blocking issue preventing pass:

  1. Root bun test run is blocked by dependency and filesystem errors
    • Repro: run bun test at repo root.
    • Observed: module resolution failures (e.g. missing zod, devos-agents) plus repeated EPERM write failures for temp/outbox paths (e.g. .tmp-*, .devos/projects/project-1/server-outbox.ndjson), resulting in many failed/error suites.
    • Expected: root test suite completes without dependency or permission blockers.
    • Fix expectation: restore workspace dependency/link integrity (notably around packages/agent-adapters, packages/agents, packages/cli) and ensure tests write only to writable locations (or run with correct permissions) for paths used by packages/create-devos-plugin/tests/*, packages/workflow/tests/*, and packages/cli/src/features/workflow/workflow-data-outbox.ts.
    • Verification: rerun bun test from repo root and confirm no module-resolution or EPERM blockers remain.

@zhangweijian97

Copy link
Copy Markdown
Collaborator Author

devos.ing implementation feedback for TASK(WORKSPACE-A157014E8DCFDAFA)-3

Review/testing summary:
Scoped review against packages/web/src/components/chat-room/chat-composer.tsx passes the acceptance goal: the new Enter && event.nativeEvent.isComposing guard short-circuits before command selection and submit logic, while non-IME Enter paths remain unchanged. However, required workspace verification is blocked because bun test does not complete in a workable state (module-resolution errors like missing zod/devos-agents and multiple filesystem EPERM failures on temp/outbox writes), so this review cannot return a passing status.

Fix instructions for the implementation agent:
Address every item below, use each body as the repair checklist, and rerun the listed verification checks.

Bugs to fix:

  1. Root bun test run is blocked by dependency and filesystem errors
    Failing command/repro: Run bun test at repository root.
    Observed: The run reports module-resolution failures (for example Cannot find package 'zod' and Cannot find package 'devos-agents') and repeated EPERM write failures for test temp/outbox paths (for example .tmp-* dirs and .devos/projects/project-1/server-outbox.ndjson), ending with many failed/error suites.
    Expected: bun test should complete without dependency-resolution or filesystem-permission blockers so workspace health and regressions can be validated.
    Likely files/code path: Workspace dependency/link setup affecting packages/agent-adapters, packages/agents, and packages/cli; temp/outbox write paths used by packages/create-devos-plugin/tests/*, packages/workflow/tests/*, and packages/cli/src/features/workflow/workflow-data-outbox.ts.
    Fix expectation: Restore missing workspace dependencies/package links and make test writes target a writable location (or adjust environment permissions) so the full root test suite can execute.
    Verification: Re-run bun test from repo root and confirm no module-resolution or EPERM blockers remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant