Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions packages/server/src/tasks/task-chat-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export async function runTaskIntake(
json: true,
});
if (result.status !== "succeeded") {
throw new Error(result.error ?? "Task creation failed");
throw new Error(readCliFailureMessage(result, "Task creation failed"));
}
return parseTaskIntakeOutput(result.commandResult?.stdout ?? "");
}
Expand All @@ -73,7 +73,9 @@ export async function runTaskRequirementIntake(
json: true,
});
if (result.status !== "succeeded") {
throw new Error(result.error ?? "Task requirement intake failed");
throw new Error(
readCliFailureMessage(result, "Task requirement intake failed"),
);
}
return parseTaskRequirementOutput(result.commandResult?.stdout ?? "");
}
Expand Down Expand Up @@ -222,6 +224,16 @@ function readErrorMessage(record: Record<string, unknown>): string {
: "unknown legacy Linear failure";
}

function readCliFailureMessage(
result: Awaited<ReturnType<CliExecutor["execute"]>>,
fallback: string,
): string {
const output = [result.commandResult?.stderr, result.commandResult?.stdout]
.map((value) => value?.trim())
.find((value) => value !== undefined && value.length > 0);
return result.error ?? output ?? fallback;
}

async function settle<T>(
run: () => Promise<T>,
): Promise<{ ok: true; value: T } | { ok: false; error: string }> {
Expand Down
28 changes: 28 additions & 0 deletions packages/server/tests/task-chat-service-failure.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { describe, expect, it } from "bun:test";
import { runTaskRequirementIntake } from "../src/tasks/task-chat-service";
import type { CliExecutor } from "../src/types/app.types";

describe("task chat service CLI failures", () => {
it("surfaces stderr from failed requirement intake commands", async () => {
const cliExecutor: CliExecutor = {
execute: async (request) => ({
status: "failed",
request,
commandResult: {
code: 1,
stdout: "",
stderr: "codex failed with exit code 1\n",
},
}),
getHistory: () => [],
};

await expect(
runTaskRequirementIntake(cliExecutor, {
request: "Build the dashboard",
projectId: "default",
answers: [],
}),
).rejects.toThrow("codex failed with exit code 1");
});
});
Loading