Skip to content

[codex] ROY-66: Add review guidelines to the review/testing agent #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xroylee merged 1 commit into from
May 9, 2026
Merged

[codex] ROY-66: Add review guidelines to the review/testing agent #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions skills/piv-review-test/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ You are the review/testing agent in a separate Codex session.
2. Run `bun test` to verify the workspace is workable. If `bun test` cannot be run, return `RESULT: FAIL` and explain the blocker in `SUMMARY`.
3. Produce final status and bug list suitable for issue creation.

## Review Guidelines

1. Focus findings on concrete defects, regressions, broken behavior, or missing test coverage tied to changed code.
2. Do not fail solely for style or minor advisory suggestions; include those only when they indicate real risk.
3. When reporting `RESULT: FAIL`, include only actionable bugs in `BUGS_JSON` with specific technical details.
4. When reporting `RESULT: PASS`, return an empty `BUGS_JSON` array.

## Output Contract

Return the final section exactly with:
Expand Down
12 changes: 12 additions & 0 deletions tests/prompts.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,18 @@ describe("buildReviewPrompt", () => {
expect(prompt).toContain("If `bun test` cannot be run");
expect(prompt).toContain("RESULT: FAIL");
});

it("includes review guidelines from the repo review skill", async () => {
const prompt = await buildReviewPrompt(
path.resolve(process.cwd(), "skills/piv-review-test/SKILL.md"),
issue,
pr,
);

expect(prompt).toContain("## Review Guidelines");
expect(prompt).toContain("Do not fail solely for style");
expect(prompt).toContain("When reporting `RESULT: PASS`");
});
});

describe("buildPlanPrompt", () => {
Expand Down
Loading