Skip to content

[codex] ROY-76: Prepare npm publishing for the adhdai package#67

Merged
0xroylee merged 6 commits into
mainfrom
codex/roy-76
May 9, 2026
Merged

[codex] ROY-76: Prepare npm publishing for the adhdai package#67
0xroylee merged 6 commits into
mainfrom
codex/roy-76

Conversation

@0xroylee

@0xroylee 0xroylee commented May 9, 2026

Copy link
Copy Markdown
Owner

Linear issue: ROY-76

This PR was created by the Agent-Driven Development Hub (ADHD.ai) workflow.

Includes:

  • plan + implement session output
  • separate review/testing session

@0xroylee

0xroylee commented May 9, 2026

Copy link
Copy Markdown
Owner Author

ADHD.ai review for ROY-76

Result: FAIL

Token usage: input 240898, output 4005, total 244903

bun test ran but failed with 2 failing config notification tests. The visible PR diff only changes package.json and adds tests/package-metadata.test.ts; I did not find a PR-specific code regression in those files. The failure is caused by this workspace’s ignored adhd-ai.local.config.ts, which disables email notifications and overrides the RESEND env expectations in tests/config.test.ts. I also could not fetch origin/main first because .git/FETCH_HEAD is not writable in this sandbox.

Bugs were detected and sent back to implementation.

@0xroylee

0xroylee commented May 9, 2026

Copy link
Copy Markdown
Owner Author

ADHD.ai review for ROY-76

Result: FAIL

Token usage: input 311544, output 4245, total 315789

bun test ran successfully with 253 passing tests, and bun run typecheck also passed. Review found a publish-prep regression: the new prepare:publish script depends on npm pack --dry-run, but npm pack --dry-run currently fails because npm invokes the prepare lifecycle and husky is not available on PATH in this workspace. I could not refresh from origin/main because git fetch origin main was blocked by .git/FETCH_HEAD: Operation not permitted.

Bugs were detected and sent back to implementation.

@0xroylee

0xroylee commented May 9, 2026

Copy link
Copy Markdown
Owner Author

ADHD.ai review for ROY-76

Result: FAIL

Token usage: input 729618, output 5236, total 734854

bun test ran successfully with 253 passing tests and 0 failures; bun run typecheck also passed, and build plus npm pack --dry-run --ignore-scripts passed when using a writable npm cache. Review found one packaging consistency issue: package.json now publishes adhdai@0.0.1, but bun.lock still records the root workspace as adhd.ai. I could not refresh origin/main because Git was blocked from writing .git/FETCH_HEAD in this sandbox.

Bugs were detected and sent back to implementation.

@0xroylee

0xroylee commented May 9, 2026

Copy link
Copy Markdown
Owner Author

ADHD.ai review for ROY-76

Result: FAIL

Token usage: input 299226, output 5231, total 304457

bun test passed locally (253 tests, 0 failures), bun run typecheck passed, and the built CLI artifact preserved its Bun shebang. However, required verification is incomplete: git fetch origin main failed with cannot open .git/FETCH_HEAD: Operation not permitted, and bun run check fails because Biome scans the gitignored adhd-ai.local.config.ts in this workspace.

Bugs were detected and sent back to implementation.

@0xroylee

0xroylee commented May 9, 2026

Copy link
Copy Markdown
Owner Author

ADHD.ai review for ROY-76

Result: PASS

Token usage: input 381045, output 3804, total 384849

Reviewed PR changes for ROY-76 and found no code bugs or missing-test issues. bun test passed with 253 tests and 0 failures; bun run check, bun run typecheck, bun run build, and npm pack --dry-run --ignore-scripts also passed when using a writable npm cache. Note: git fetch origin main was blocked by the sandbox with cannot open .git/FETCH_HEAD: Operation not permitted, so review used the checked-out branch against the existing local main ref.

No bugs found.

@0xroylee 0xroylee marked this pull request as ready for review May 9, 2026 07:53
@0xroylee 0xroylee merged commit b9de2f8 into main May 9, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant