Open
Conversation
LuisPH3
previously approved these changes
Mar 23, 2026
| knownMissingAPIs = namespaceMap{ | ||
| "eth": { | ||
| "SendRawTransactionSync": struct{}{}, | ||
| "GetStorageValues": struct{}{}, |
Contributor
There was a problem hiding this comment.
added to the backlog:
https://github.com/0xsoniclabs/sonic-admin/issues/655
tests/state_test.go
Outdated
| require.NoError(t, st.CheckFailure(t, err)) | ||
| err = st.CheckFailure(t, err) | ||
| if err != nil && strings.Contains(err.Error(), | ||
| "post-state root does not match the pre-state root, indicates an error in the test:") { |
Collaborator
There was a problem hiding this comment.
This is a bit unsatisfying. This error does not sound like it is related to the lack of support of the intermediate root. Is there a way to link this up more clearly?
Contributor
Author
There was a problem hiding this comment.
I removed the skipping and used the block root rather than the intermediate root.
Contributor
Author
|
The last commit fixes nil values for the storage keys in the access list. This has been fixed in geth in #33976 which is not part of 1.17.1. |
Codecov Report❌ Patch coverage is
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the geth dependency to 1.17.1. The stateDB interface has been extended by the
isNewContractfunction and theselfdestruct6780has been removed.The ethereum tests runner has been updated now making use of a feature that is not supported by carmen, these checks are simply ignored.