Skip to content

Conversation

@frankdekker
Copy link
Member

@frankdekker frankdekker commented Jun 15, 2025

Fixes warning:

PHP Deprecated:  DigitalRevolution\CodeCoverageInspection\Command\InspectCommand::__construct(): 
Implicitly marking parameter $name as nullable is deprecated, the explicit nullable type must be used 
instead in /home/runner/work/symfony-log-viewer-bundle/symfony-log-viewer-bundle/vendor/digitalrevolution/phpunit-file-coverage-inspection/src/Command/InspectCommand.php on line 31

Copilot AI review requested due to automatic review settings June 15, 2025 12:11
@frankdekker frankdekker requested a review from a team as a code owner June 15, 2025 12:11
@frankdekker frankdekker requested a review from bram123 June 15, 2025 12:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR resolves deprecation notices by removing the implicitly nullable $name parameter from the InspectCommand constructor. The changes include:

  • Removing the $name parameter from the constructor signature.
  • Adjusting the call to the parent constructor to no longer pass a parameter.
Comments suppressed due to low confidence (1)

src/Command/InspectCommand.php:31

  • Removing the $name parameter from the constructor fixes the deprecation warning; however, ensure that this change aligns with command registration requirements and that no external usage depends on providing a command name.
public function __construct()

@frankdekker frankdekker changed the title Fixes deprecation notices Fixes deprecation notice in InspectCommand Jun 15, 2025
bram123
bram123 previously approved these changes Jun 16, 2025
@frankdekker frankdekker dismissed bram123’s stale review October 6, 2025 18:42

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants