Skip to content

Conversation

@edif2008
Copy link
Member

@edif2008 edif2008 commented Jan 15, 2025

This will reduce the amount of pipelines executed in PRs to once instead of twice due to two targets matching previously in PRs.

Overview

When running pipelines on existing Pull Requests, it's very likely that the testing pipelines will be executed twice. That is becuase both push and pull_request criteria match when pushing new code on the branch that has an open Pull Request.

This PR adjusts the push target to only be executed on main branch to reduce the amount of pipelines executed on Pull Requests. A similar thing has been done for load-secrets-action's testing pipeline as part of 1Password/load-secrets-action#87, followed by 1Password/load-secrets-action#90.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

How To Test

Check that the pipeline will only execute the Test and Validate once from the pull_request target. Compare that with #505:

image

This will reduce the amount of pipelines executed in PRs to once instead of twice due to two targets matching previously in PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants