Added authentication for terraform output and terraform taint commands
#556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 1Password Terraform shell plugin successfully provides credentials for commands like `terraform apply` and `terraform init`, but it specifically fails to provide them for the `terraform output` command. A key factor is the use of a remote state file in S3, which requires authentication. The issue is not present when credentials are set directly as environment variables. As an example, the `output` subcommand is missing from this list. I suspect this causes the plugin to omit credential injection for the `output` command. As a result, the terraform process fails to receive the credentials in its environment. Instead terraform falls back to the configuration in `provider.tf` file. Since that file doesn't contain explicit credentials, the backend authentication fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The Terraform shell plugin provides credentials for commands like
terraform outputandterraform taint.Type of change
How To Test
As an example, the
outputsubcommand is missing from "needsauth" list. This causes the plugin to omit credential injection for theoutputcommand.A key factor is the use of a remote state file in S3, which requires authentication.
As a result, the terraform process fails to receive the credentials in its environment. Instead terraform falls back to the configuration in
provider.tffile. Since that file doesn't contain explicit credentials, the backend authentication fails.Changelog
Added credential injection to the environment for
terraform outputandterraform taintcommands.